Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10807078: Address review comments from a previous CL. (Closed)

Created:
8 years, 5 months ago by siva
Modified:
8 years, 4 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Address review comments from previous CL. Committed: https://code.google.com/p/dart/source/detail?r=10608

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M vm/dart_api_message.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
siva
8 years, 5 months ago (2012-07-23 23:53:49 UTC) #1
regis
LGTM https://chromiumcodereview.appspot.com/10807078/diff/10001/vm/dart_api_message.cc File vm/dart_api_message.cc (right): https://chromiumcodereview.appspot.com/10807078/diff/10001/vm/dart_api_message.cc#newcode194 vm/dart_api_message.cc:194: if (class_id == kArray || class_id == kImmutableArray) ...
8 years, 5 months ago (2012-07-24 13:49:25 UTC) #2
siva
The original CL was subsumed by a larger CL which stream lined the use of ...
8 years, 4 months ago (2012-08-13 20:38:24 UTC) #3
regis
8 years, 4 months ago (2012-08-13 21:01:56 UTC) #4 
LGTM

Powered by Google App Engine
This is Rietveld 408576698