Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2095)

Issue 10807031: Favor free list allocation to bump pointer allocation. (Closed)

Created:
8 years, 5 months ago by cshapiro
Modified:
8 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Favor free list allocation to bump pointer allocation. This change improves the utilization of the smallest size classes on benchmarks performing old space allocations including Splay, Box2D, and Dart2JSCompileAll. Initial measurements showed that free list allocation was slightly slower than bump pointer allocation. Profiling identified that free list allocation spent most of its time searching for a matching size class. To eliminate this overhead, a bitmap index has been added resulting in no appreciable difference in running time between either method. Committed: https://code.google.com/p/dart/source/detail?r=9773

Patch Set 1 #

Total comments: 6

Patch Set 2 : address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -6 lines) Patch
M runtime/vm/freelist.h View 3 chunks +8 lines, -0 lines 0 comments Download
M runtime/vm/freelist.cc View 1 3 chunks +49 lines, -4 lines 0 comments Download
M runtime/vm/pages.cc View 4 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
cshapiro
8 years, 5 months ago (2012-07-19 05:08:53 UTC) #1
siva
http://codereview.chromium.org/10807031/diff/1/runtime/vm/freelist.cc File runtime/vm/freelist.cc (right): http://codereview.chromium.org/10807031/diff/1/runtime/vm/freelist.cc#newcode163 runtime/vm/freelist.cc:163: intptr_t size = length * kObjectAlignment; Shouldn't this be ...
8 years, 5 months ago (2012-07-19 19:38:23 UTC) #2
cshapiro
http://codereview.chromium.org/10807031/diff/1/runtime/vm/freelist.cc File runtime/vm/freelist.cc (right): http://codereview.chromium.org/10807031/diff/1/runtime/vm/freelist.cc#newcode163 runtime/vm/freelist.cc:163: intptr_t size = length * kObjectAlignment; I think so. ...
8 years, 5 months ago (2012-07-19 22:34:29 UTC) #3
siva
8 years, 5 months ago (2012-07-20 01:28:37 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698