Issue 10806099: Some cleanups.

Issue 10806099: Some cleanups. (Closed)

Created:
8 years, 5 months ago by srdjan

Modified:
8 years, 5 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Vyacheslav Egorov (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Some cleanups. Committed: https://code.google.com/p/dart/source/detail?r=9874

Patch Set 6 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -44 lines)			Patch
M	runtime/vm/flow_graph_allocator.h	View	1 2 3	4 chunks	+9 lines, -12 lines	0 comments	Download
M	runtime/vm/flow_graph_allocator.cc	View	1	8 chunks	+27 lines, -28 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2 3 4 5	1 chunk	+7 lines, -3 lines	0 comments	Download
M	runtime/vm/locations.h	View	1 2	3 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

hausner

lgtm https://chromiumcodereview.appspot.com/10806099/diff/10001/runtime/vm/flow_graph_allocator.h File runtime/vm/flow_graph_allocator.h (right): https://chromiumcodereview.appspot.com/10806099/diff/10001/runtime/vm/flow_graph_allocator.h#newcode319 runtime/vm/flow_graph_allocator.h:319: finger_() {} I actually like the old formatting ...

8 years, 5 months ago (2012-07-24 23:53:47 UTC) #2

srdjan

https://chromiumcodereview.appspot.com/10806099/diff/10001/runtime/vm/flow_graph_allocator.h File runtime/vm/flow_graph_allocator.h (right): https://chromiumcodereview.appspot.com/10806099/diff/10001/runtime/vm/flow_graph_allocator.h#newcode319 runtime/vm/flow_graph_allocator.h:319: finger_() {} On 2012/07/24 23:53:47, hausner wrote: > I ...

8 years, 5 months ago (2012-07-24 23:57:16 UTC) #3

srdjan

Also added a fix to CheckStackOverflowComp::MakeLocationSummary for IA32

8 years, 5 months ago (2012-07-25 00:10:16 UTC) #4

still lgtm

Expand Messages | Collapse Messages