Issue 10805085: The mirror tests made the invalid assumption that the library with the tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10805085: The mirror tests made the invalid assumption that the library with the tests (Closed)

Created:
8 years, 5 months ago by rmacnak

Modified:
8 years, 5 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

The mirror tests made the invalid assumption that the library with the tests will be the root library at run time. They should instead get the library mirror by name. Committed: https://code.google.com/p/dart/source/detail?r=9858

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	tests/lib/lib.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	tests/lib/mirrors/mirrors_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

8 years, 5 months ago (2012-07-24 17:21:31 UTC) #2

LGTM -ip

https://chromiumcodereview.appspot.com/10805085/diff/1/tests/lib/mirrors/mirr...
File tests/lib/mirrors/mirrors_test.dart (right):

https://chromiumcodereview.appspot.com/10805085/diff/1/tests/lib/mirrors/mirr...
tests/lib/mirrors/mirrors_test.dart:13: 
empty space...

Expand Messages | Collapse Messages