Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 10805017: Add a "help" command to Pub. (Closed)

Created:
8 years, 5 months ago by nweiz
Modified:
8 years, 5 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a "help" command to Pub. Committed: https://code.google.com/p/dart/source/detail?r=9765

Patch Set 1 #

Patch Set 2 : Fix test failures #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -22 lines) Patch
A utils/pub/command_help.dart View 1 chunk +23 lines, -0 lines 0 comments Download
M utils/pub/command_install.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M utils/pub/command_list.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M utils/pub/command_update.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M utils/pub/command_version.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M utils/pub/pub.dart View 1 9 chunks +65 lines, -22 lines 2 comments Download
M utils/tests/pub/pub_test.dart View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
8 years, 5 months ago (2012-07-18 23:01:15 UTC) #1
Jennifer Messerly
lgtm! https://chromiumcodereview.appspot.com/10805017/diff/3001/utils/pub/pub.dart File utils/pub/pub.dart (right): https://chromiumcodereview.appspot.com/10805017/diff/3001/utils/pub/pub.dart#newcode224 utils/pub/pub.dart:224: void printUsage([String description=null]) { nit: you can do ...
8 years, 5 months ago (2012-07-19 01:00:51 UTC) #2
nweiz
8 years, 5 months ago (2012-07-19 18:09:16 UTC) #3
https://chromiumcodereview.appspot.com/10805017/diff/3001/utils/pub/pub.dart
File utils/pub/pub.dart (right):

https://chromiumcodereview.appspot.com/10805017/diff/3001/utils/pub/pub.dart#...
utils/pub/pub.dart:224: void printUsage([String description=null]) {
On 2012/07/19 01:00:51, John Messerly wrote:
> nit: you can do [String description] since the =null is implied

Done.

Powered by Google App Engine
This is Rietveld 408576698