Issue 10805008: Revert "Revert "Introduce Goto instructions to the flow graph.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10805008: Revert "Revert "Introduce Goto instructions to the flow graph."" (Closed)

Created:
8 years, 5 months ago by Kevin Millikin (Google)

Modified:
8 years, 5 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Revert "Revert "Introduce Goto instructions to the flow graph."" Reapply svn revision 9731 with a bug fix. The original review is at http://chromiumcodereview.appspot.com/10735071/ R=vegorov@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9738

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+327 lines, -236 lines)			Patch
M	runtime/vm/flow_graph_allocator.cc	View	2 chunks	+109 lines, -86 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	16 chunks	+106 lines, -123 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	3 chunks	+5 lines, -7 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	3 chunks	+13 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.h	View	5 chunks	+28 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	5 chunks	+54 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Kevin Millikin (Google)

There was a bug in the liveness introduction of definitions for phis. The fix is ...

8 years, 5 months ago (2012-07-18 12:55:13 UTC) #1

LGTM