Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 10801008: Disable GVN for interceptors and fields. (Closed)

Created:
8 years, 5 months ago by floitsch
Modified:
8 years, 5 months ago
Reviewers:
Johnni Winther, kasperl
CC:
reviews_dartlang.org, Mads Ager (google)
Visibility:
Public.

Description

Disable GVN for interceptors and fields. Fixes issue 4086. Committed: https://code.google.com/p/dart/source/detail?r=9735

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
M lib/compiler/implementation/ssa/nodes.dart View 2 chunks +1 line, -4 lines 0 comments Download
A + tests/language/gvn_field_access_test.dart View 1 chunk +10 lines, -5 lines 0 comments Download
A + tests/language/gvn_interceptor_test.dart View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
floitsch
8 years, 5 months ago (2012-07-18 10:37:32 UTC) #1
Johnni Winther
8 years, 5 months ago (2012-07-18 11:15:11 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698