Issue 10800002: Hide names of internal classes from the user by mapping them to the documented

Issue 10800002: Hide names of internal classes from the user by mapping them to the documented (Closed)

Created:
8 years, 5 months ago by regis

Modified:
8 years, 5 months ago

Reviewers:
srdjan, cshapiro

CC:
reviews_dartlang.org, vm-dev_dartlang.org, gbracha

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Hide names of internal classes from the user by mapping them to the documented interfaces they implement. Committed: https://code.google.com/p/dart/source/detail?r=9748

Patch Set 4 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+378 lines, -160 lines)			Patch
M	runtime/lib/error.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/class_finalizer.cc	View	1 2 3	7 chunks	+56 lines, -58 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View	1 2 3	4 chunks	+11 lines, -20 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/object.h	View	1 2 3	20 chunks	+57 lines, -22 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2 3	21 chunks	+122 lines, -30 lines	0 comments	Download
M	runtime/vm/object_store.h	View	1 2 3	3 chunks	+9 lines, -0 lines	0 comments	Download
M	runtime/vm/object_store.cc	View	1 2 3	3 chunks	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 2 3	12 chunks	+18 lines, -18 lines	0 comments	Download
M	tests/language/type_cast_vm_test.dart	View	1 2 3	7 chunks	+7 lines, -6 lines	0 comments	Download
M	tests/language/type_vm_test.dart	View	1 2 3	7 chunks	+91 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

srdjan

https://chromiumcodereview.appspot.com/10800002/diff/1/runtime/vm/raw_object.h File runtime/vm/raw_object.h (right): https://chromiumcodereview.appspot.com/10800002/diff/1/runtime/vm/raw_object.h#newcode379 runtime/vm/raw_object.h:379: RawString* user_visible_name_; Let's talk tomorrow if we need that ...

8 years, 5 months ago (2012-07-18 00:41:39 UTC) #2

turnidge

Gilad, What do you think of doing the same thing in the mirrors implementation? Todd ...

8 years, 5 months ago (2012-07-18 05:12:34 UTC) #3

regis

Please, have another look. I'll still add a test. Thanks, Regis

8 years, 5 months ago (2012-07-18 20:28:57 UTC) #4

srdjan

LGTM https://chromiumcodereview.appspot.com/10800002/diff/15/runtime/vm/object.cc File runtime/vm/object.cc (right): https://chromiumcodereview.appspot.com/10800002/diff/15/runtime/vm/object.cc#newcode1060 runtime/vm/object.cc:1060: RawString* Class::UserVisibleName() const { Maybe simpler: if (FLAG_show_internal_names) ...

8 years, 5 months ago (2012-07-18 21:25:29 UTC) #5

regis

8 years, 5 months ago (2012-07-18 21:40:11 UTC) #6

Thanks!

I have also updated the tests.

-- Regis

https://chromiumcodereview.appspot.com/10800002/diff/15/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/10800002/diff/15/runtime/vm/object.cc#...
runtime/vm/object.cc:1060: RawString* Class::UserVisibleName() const {
On 2012/07/18 21:25:29, srdjan wrote:
> Maybe simpler:
> if (FLAG_show_internal_names) return Name();
> switch (id()) {
>   case ....
>   default:
>     return Name();
> }

Done.

https://chromiumcodereview.appspot.com/10800002/diff/15/runtime/vm/object_sto...
File runtime/vm/object_store.h (right):

https://chromiumcodereview.appspot.com/10800002/diff/15/runtime/vm/object_sto...
runtime/vm/object_store.h:133: integer_implementation_class_ = value.raw(); }
On 2012/07/18 21:25:29, srdjan wrote:
> Curly brace to next line.

Done.

Expand Messages | Collapse Messages