Issue 10796084: Use 'default:' for the first bailout-case with more than one target.

Issue 10796084: Use 'default:' for the first bailout-case with more than one target. (Closed)

Created:
8 years, 5 months ago by floitsch

Modified:
8 years, 5 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use 'default:' for the first bailout-case with more than one target. Committed: https://code.google.com/p/dart/source/detail?r=9805

Patch Set 2 : More comments and different field name. #

Total comments: 4

Patch Set 3 : Address comment. #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -5 lines)			Patch
	M	lib/compiler/implementation/ssa/codegen.dart	View	1 2	4 chunks	+27 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ricow1

Still LGTM https://chromiumcodereview.appspot.com/10796084/diff/3001/lib/compiler/implementation/ssa/codegen.dart File lib/compiler/implementation/ssa/codegen.dart (right): https://chromiumcodereview.appspot.com/10796084/diff/3001/lib/compiler/implementation/ssa/codegen.dart#newcode2872 lib/compiler/implementation/ssa/codegen.dart:2872: * they used the [:default::] clause.'s strange ...

8 years, 5 months ago (2012-07-23 12:03:59 UTC) #4

floitsch

8 years, 5 months ago (2012-07-23 13:04:25 UTC) #5

https://chromiumcodereview.appspot.com/10796084/diff/3001/lib/compiler/implem...
File lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10796084/diff/3001/lib/compiler/implem...
lib/compiler/implementation/ssa/codegen.dart:2872: * they used the [:default::]
clause.'s
On 2012/07/23 12:03:59, ricow1 wrote:
> strange end of comment

Done.

https://chromiumcodereview.appspot.com/10796084/diff/3001/lib/compiler/implem...
lib/compiler/implementation/ssa/codegen.dart:2874: final List<bool>
bailoutHasUsedDefaultClauseStack;
On 2012/07/23 12:03:59, ricow1 wrote:
> defaultClauseUsedInBailoutStack - one character smaller:-)

Done.

Expand Messages | Collapse Messages