Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 10796075: - Tighten assertions around store buffers. (Closed)

Created:
8 years, 5 months ago by Ivan Posva
Modified:
8 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

- Tighten assertions around store buffers. - Use the correct object when filtering in store barriers. Committed: https://code.google.com/p/dart/source/detail?r=9797

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M runtime/vm/heap.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/heap.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 2 chunks +10 lines, -3 lines 0 comments Download
M runtime/vm/store_buffer.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ivan Posva
TBR
8 years, 5 months ago (2012-07-21 01:08:01 UTC) #1
siva
8 years, 5 months ago (2012-07-23 16:31:08 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698