Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 10796004: Consolidate a few fields in RawFunction using bitfields. (Closed)

Created:
8 years, 5 months ago by turnidge
Modified:
8 years, 4 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Consolidate a few fields in RawFunction using bitfields. Remove kAbstract from the list of function kinds. It now has its own dedicated bit. This allows us to distinguish abstract methods from abstract getters and setters. Committed: https://code.google.com/p/dart/source/detail?r=10087

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -90 lines) Patch
M runtime/vm/code_descriptors_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/code_patcher_ia32_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/code_patcher_x64_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/compiler.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 4 chunks +4 lines, -17 lines 0 comments Download
M runtime/vm/object.h View 1 2 4 chunks +11 lines, -13 lines 0 comments Download
M runtime/vm/object.cc View 1 2 6 chunks +30 lines, -22 lines 0 comments Download
M runtime/vm/object_test.cc View 1 2 5 chunks +17 lines, -8 lines 0 comments Download
M runtime/vm/parser.cc View 1 2 11 chunks +10 lines, -5 lines 0 comments Download
M runtime/vm/raw_object.h View 1 2 2 chunks +73 lines, -11 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 2 2 chunks +7 lines, -5 lines 0 comments Download
M runtime/vm/runtime_entry_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stub_code_ia32_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stub_code_x64_test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/unit_test.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
turnidge
Hi Ivan, Here's the change we talked about earlier today which makes whether a function ...
8 years, 5 months ago (2012-07-18 04:57:15 UTC) #1
Ivan Posva
8 years, 5 months ago (2012-07-18 22:56:38 UTC) #2
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698