Issue 10790079: Use a lockfile to persist Pub's installed version constellation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10790079: Use a lockfile to persist Pub's installed version constellation. (Closed)

Created:
8 years, 5 months ago by nweiz

Modified:
8 years, 5 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use a lockfile to persist Pub's installed version constellation. This fixes a race condition in r9767 caused by issue 4155. Committed: https://code.google.com/p/dart/source/detail?r=9824

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+656 lines, -106 lines)			Patch
M	utils/pub/entrypoint.dart	View	6 chunks	+72 lines, -29 lines	0 comments	Download
M	utils/pub/git_source.dart	View	7 chunks	+41 lines, -14 lines	0 comments	Download
M	utils/pub/io.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	utils/pub/lock_file.dart	View	3 chunks	+20 lines, -1 line	0 comments	Download
M	utils/pub/package.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	utils/pub/pubspec.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/pub/repo_source.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/pub/source.dart	View	3 chunks	+35 lines, -11 lines	0 comments	Download
M	utils/pub/utils.dart	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	utils/pub/version_solver.dart	View	4 chunks	+37 lines, -11 lines	0 comments	Download
M	utils/tests/pub/lock_file_test.dart	View	2 chunks	+27 lines, -1 line	0 comments	Download
M	utils/tests/pub/pub_test.dart	View	2 chunks	+285 lines, -0 lines	0 comments	Download
M	utils/tests/pub/pubspec_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	utils/tests/pub/test_pub.dart	View	2 chunks	+54 lines, -32 lines	1 comment	Download
M	utils/tests/pub/version_solver_test.dart	View	4 chunks	+66 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

nweiz

The only changes are to serve() in test_pub.dart and the addition of sleep() in utils.dart ...

8 years, 5 months ago (2012-07-19 20:48:23 UTC) #1

Jennifer Messerly

8 years, 5 months ago (2012-07-20 00:59:17 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10790079/diff/1/utils/tests/pub/test_p...
File utils/tests/pub/test_pub.dart (right):

https://chromiumcodereview.appspot.com/10790079/diff/1/utils/tests/pub/test_p...
utils/tests/pub/test_pub.dart:118: // *seems* to be enough to ensure that the
server is actually closed, but I'm
agree, I suspect it works as long as it gets to the event loop, but 10ms doesn't
hurt either.

Expand Messages | Collapse Messages