Issue 10790021: Allow the Git source to depend on a specific revision.

Issue 10790021: Allow the Git source to depend on a specific revision. (Closed)

Created:
8 years, 5 months ago by nweiz

Modified:
8 years, 5 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Allow the Git source to depend on a specific revision. Committed: https://code.google.com/p/dart/source/detail?r=9693

Patch Set 1 #

Patch Set 2 : Small refactoring #

Total comments: 6

Patch Set 3 : Code review changes #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+315 lines, -158 lines)			Patch
M	utils/pub/git_source.dart	View	1 2	5 chunks	+68 lines, -8 lines	0 comments	Download
M	utils/tests/pub/pub_test.dart	View		1 chunk	+172 lines, -135 lines	0 comments	Download
M	utils/tests/pub/test_pub.dart	View	1 2	6 chunks	+75 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

A couple of nits, but LGTM. Yay for removing a level of nesting in the ...

8 years, 5 months ago (2012-07-17 00:10:31 UTC) #2

nweiz

8 years, 5 months ago (2012-07-17 01:06:55 UTC) #3

https://chromiumcodereview.appspot.com/10790021/diff/2001/utils/pub/git_sourc...
File utils/pub/git_source.dart (right):

https://chromiumcodereview.appspot.com/10790021/diff/2001/utils/pub/git_sourc...
utils/pub/git_source.dart:149: Future _checkout(String repoPath, String ref) {
On 2012/07/17 00:10:31, Bob Nystrom wrote:
> "_checkOut". I know the command is all lowercase in git, but it seems like the
> method should be camel-cased to me.

Done.

https://chromiumcodereview.appspot.com/10790021/diff/2001/utils/pub/git_sourc...
utils/pub/git_source.dart:152: if (!result.success) throw 'Git failed.';
On 2012/07/17 00:10:31, Bob Nystrom wrote:
> Should handle this more gracefully, or at least have a TODO to do so.

I'm not sure I agree. Since we're piping stderr, so any errors will be presented
by Git more clearly than we could do.

https://chromiumcodereview.appspot.com/10790021/diff/2001/utils/tests/pub/tes...
File utils/tests/pub/test_pub.dart (right):

https://chromiumcodereview.appspot.com/10790021/diff/2001/utils/tests/pub/tes...
utils/tests/pub/test_pub.dart:273: * current test is running on a builbot in
which case we expect git to be
On 2012/07/17 00:10:31, Bob Nystrom wrote:
> "buildbot".

Done.

Expand Messages | Collapse Messages