Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 10787021: Fix type checking of void type. (Closed)

Created:
8 years, 5 months ago by regis
Modified:
8 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix type checking of void type. Fix library and tests accordingly. Add new test. Disable new test for dart2js. Disable some now failing co19 tests (new issue 158 filed). Hide internal VM String types from user (not complete). Committed: https://code.google.com/p/dart/source/detail?r=9681

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -144 lines) Patch
M runtime/bin/directory_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/http_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/mime_multipart_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/process_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/byte_array.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/byte_array.dart View 40 chunks +40 lines, -40 lines 0 comments Download
M runtime/vm/code_generator.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/debugger_api_impl_test.cc View 6 chunks +20 lines, -20 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 2 chunks +20 lines, -14 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 3 chunks +20 lines, -19 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 3 chunks +20 lines, -19 lines 0 comments Download
M runtime/vm/heap_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 4 chunks +14 lines, -1 line 0 comments Download
M runtime/vm/snapshot_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M samples/chat/chat_server_lib.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/language/generics_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/type_cast_vm_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/language/type_vm_test.dart View 12 chunks +12 lines, -12 lines 0 comments Download
A + tests/language/void_type_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M utils/tests/pub/lock_file_test.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
regis
Second try, now with corrections to utils/tests/pub/lock_file_test.dart and to samples/chat/chat_server_lib.dart which were both wrongly using ...
8 years, 5 months ago (2012-07-16 21:23:22 UTC) #1
siva
8 years, 5 months ago (2012-07-16 21:33:36 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698