Minor changes based on the profile while running dart2js compile all.

Minor changes based on the profile while running dart2js compile all.
Committed: https://code.google.com/p/dart/source/detail?r=9720

[srdjan, 2012-07-13 23:22:23]

LGTM

https://chromiumcodereview.appspot.com/10785007/diff/5001/vm/object.cc
File vm/object.cc (right):

https://chromiumcodereview.appspot.com/10785007/diff/5001/vm/object.cc#newcod...
vm/object.cc:1943: bool EqualsIgnoringPrivate(const String& name, const String&
lookup_name) {
Compare raws.

https://chromiumcodereview.appspot.com/10785007/diff/5001/vm/object.h
File vm/object.h (right):

https://chromiumcodereview.appspot.com/10785007/diff/5001/vm/object.h#newcode...
vm/object.h:5150: ASSERT(begin_index >= 0);
Compare raws as well.

https://chromiumcodereview.appspot.com/10785007/diff/5001/vm/object.h#newcode...
vm/object.h:5151: ASSERT(begin_index == 0 || begin_index < str.Length());
Add parenthesis

[siva, 2012-07-16 18:29:23]

Addressed review comments.

I also made EqualsIgnoringPrivate an instance method of OneByteString instead of
a static method.

PTAL.

Original: Dart2JSCompileAll(RunTime): 735662
With Changes: Dart2JSCompileAll(RunTime): 670089

https://chromiumcodereview.appspot.com/10785007/diff/5001/vm/object.cc
File vm/object.cc (right):

https://chromiumcodereview.appspot.com/10785007/diff/5001/vm/object.cc#newcod...
vm/object.cc:1943: bool EqualsIgnoringPrivate(const String& name, const String&
lookup_name) {
On 2012/07/13 23:22:23, srdjan wrote:
> Compare raws.

Done.

https://chromiumcodereview.appspot.com/10785007/diff/5001/vm/object.h
File vm/object.h (right):

https://chromiumcodereview.appspot.com/10785007/diff/5001/vm/object.h#newcode...
vm/object.h:5150: ASSERT(begin_index >= 0);
I don't think we can do a raw comparision and return here as we are trying to
see equality of a substring (begin_index, len).

On 2012/07/13 23:22:23, srdjan wrote:
> Compare raws as well.

https://chromiumcodereview.appspot.com/10785007/diff/5001/vm/object.h#newcode...
vm/object.h:5151: ASSERT(begin_index == 0 || begin_index < str.Length());
On 2012/07/13 23:22:23, srdjan wrote:
> Add parenthesis

Done.

[srdjan, 2012-07-16 20:42:07]

LGTM

https://chromiumcodereview.appspot.com/10785007/diff/8001/vm/object.h
File vm/object.h (right):

https://chromiumcodereview.appspot.com/10785007/diff/8001/vm/object.h#newcode...
vm/object.h:3194: intptr_t len) const;
Add comment: begin_index of 'str' or 'this'?

https://chromiumcodereview.appspot.com/10785007/diff/8001/vm/object.h#newcode...
vm/object.h:3337: bool EqualsIgnoringPrivate(const OneByteString& str) const;
I think it would be clearer to name it EqualsIgnoresPrivateKey ('Key' is the
key).

[siva, 2012-07-17 19:15:21]

https://chromiumcodereview.appspot.com/10785007/diff/8001/vm/object.h
File vm/object.h (right):

https://chromiumcodereview.appspot.com/10785007/diff/8001/vm/object.h#newcode...
vm/object.h:3194: intptr_t len) const;
On 2012/07/16 20:42:07, srdjan wrote:
> Add comment: begin_index of 'str' or 'this'?

Done.

https://chromiumcodereview.appspot.com/10785007/diff/8001/vm/object.h#newcode...
vm/object.h:3337: bool EqualsIgnoringPrivate(const OneByteString& str) const;
On 2012/07/16 20:42:07, srdjan wrote:
> I think it would be clearer to name it EqualsIgnoresPrivateKey ('Key' is the
> key).

Done.

[turnidge, 2012-07-18 05:19:07]

lgtm