Issue 10784020: Revert fix for type checking of void type, because some top level tests fail.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10784020: Revert fix for type checking of void type, because some top level tests fail. (Closed)

Created:
8 years, 5 months ago by regis

Modified:
8 years, 5 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Revert fix for type checking of void type, because some top level tests fail. Committed: https://code.google.com/p/dart/source/detail?r=9673

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+142 lines, -253 lines)			Patch
M	runtime/bin/directory_impl.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/http_parser.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/mime_multipart_parser.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/process_impl.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/lib/byte_array.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/lib/byte_array.dart	View	40 chunks	+40 lines, -40 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/debugger_api_impl_test.cc	View	6 chunks	+20 lines, -20 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	2 chunks	+14 lines, -20 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	3 chunks	+19 lines, -20 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	3 chunks	+19 lines, -20 lines	0 comments	Download
M	runtime/vm/heap_test.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	4 chunks	+1 line, -14 lines	0 comments	Download
M	runtime/vm/snapshot_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	tests/language/generics_test.dart	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	tests/language/language_dart2js.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/type_cast_vm_test.dart	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/language/type_vm_test.dart	View	12 chunks	+12 lines, -12 lines	0 comments	Download
D	tests/language/void_type_test.dart	View	1 chunk	+0 lines, -84 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages