Issue 10780029: ArrayBuffer constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10780029: ArrayBuffer constructor (Closed)

Created:
8 years, 5 months ago by sra1

Modified:
8 years, 5 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org, Anton Muhin

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

ArrayBuffer constructor Dartium custom constructor still needs to be written. Committed: https://code.google.com/p/dart/source/detail?r=9718

Patch Set 1 : #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+122 lines, -6 lines)			Patch
M	lib/dom/dom.dart	View	2 chunks	+10 lines, -1 line	0 comments	Download
M	lib/dom/frog/dom_frog.dart	View	2 chunks	+11 lines, -1 line	0 comments	Download
M	lib/dom/idl/dart/dart.idl	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View	2 chunks	+11 lines, -1 line	0 comments	Download
M	lib/html/frog/html_frog.dart	View	2 chunks	+11 lines, -1 line	0 comments	Download
M	tests/html/html.status	View	3 chunks	+4 lines, -1 line	0 comments	Download
A	tests/html/typed_arrays_5_test.dart	View	1 chunk	+30 lines, -0 lines	1 comment	Download
A	tests/html/typed_arrays_arraybuffer_test.dart	View	1 chunk	+41 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vsm

8 years, 5 months ago (2012-07-17 19:55:40 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10780029/diff/3001/tests/html/typed_ar...
File tests/html/typed_arrays_5_test.dart (right):

https://chromiumcodereview.appspot.com/10780029/diff/3001/tests/html/typed_ar...
tests/html/typed_arrays_5_test.dart:14: var a = new Float32Array(1024);
Will this actually generate different code then the below in dart2js?

Expand Messages | Collapse Messages