Issue 10779026: Fix triggering of method optimization: increment counter at all IC calls and return as before but a…

Issue 10779026: Fix triggering of method optimization: increment counter at all IC calls and return as before but a… (Closed)

Created:
8 years, 5 months ago by srdjan

Modified:
8 years, 5 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix triggering of method optimization: increment counter at all IC calls and return as before but allow triggering of optimization only at exit of the method. Committed: https://code.google.com/p/dart/source/detail?r=9710

Patch Set 1 #

Patch Set 2 : #

Total comments: 7

Patch Set 3 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -34 lines)			Patch
	M	runtime/vm/stub_code_ia32.cc	View	1 2	1 chunk	+15 lines, -18 lines	0 comments	Download
	M	runtime/vm/stub_code_x64.cc	View	1 2	1 chunk	+16 lines, -16 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10779026/diff/3001/runtime/vm/stub_code_ia32.cc File runtime/vm/stub_code_ia32.cc (left): https://chromiumcodereview.appspot.com/10779026/diff/3001/runtime/vm/stub_code_ia32.cc#oldcode1574 runtime/vm/stub_code_ia32.cc:1574: __ CallRuntime(kOptimizeInvokedFunctionRuntimeEntry); Is this runtime entry still needed? ...

8 years, 5 months ago (2012-07-17 16:08:06 UTC) #2

srdjan

8 years, 5 months ago (2012-07-17 16:25:06 UTC) #3

Thanks!

https://chromiumcodereview.appspot.com/10779026/diff/3001/runtime/vm/stub_cod...
File runtime/vm/stub_code_ia32.cc (left):

https://chromiumcodereview.appspot.com/10779026/diff/3001/runtime/vm/stub_cod...
runtime/vm/stub_code_ia32.cc:1574: __
CallRuntime(kOptimizeInvokedFunctionRuntimeEntry);
On 2012/07/17 16:08:06, regis wrote:
> Is this runtime entry still needed?

Yes, from ReturnInstr::EmitNativeCode.

https://chromiumcodereview.appspot.com/10779026/diff/3001/runtime/vm/stub_cod...
File runtime/vm/stub_code_ia32.cc (right):

https://chromiumcodereview.appspot.com/10779026/diff/3001/runtime/vm/stub_cod...
runtime/vm/stub_code_ia32.cc:1573: // As long as VM has no OSR do not optimize
in the middle of the function
On 2012/07/17 16:08:06, regis wrote:
> OSR? On-stack replacement?

Yes.

https://chromiumcodereview.appspot.com/10779026/diff/3001/runtime/vm/stub_cod...
File runtime/vm/stub_code_x64.cc (left):

https://chromiumcodereview.appspot.com/10779026/diff/3001/runtime/vm/stub_cod...
runtime/vm/stub_code_x64.cc:1546: __
CallRuntime(kOptimizeInvokedFunctionRuntimeEntry);
On 2012/07/17 16:08:06, regis wrote:
> ditto

ditto.

Expand Messages | Collapse Messages