Add a limited version of ParameterMirrors that can only tell whether they are

Add a limited version of ParameterMirrors that can only tell whether they are
optional. Add Dart_FunctionParameterCounts. Drop passing isSimpleValue to
instance mirrors: they can compute this on the Dart-side.
Committed: https://code.google.com/p/dart/source/detail?r=9683

[turnidge, 2012-07-13 23:37:12]

https://chromiumcodereview.appspot.com/10778005/diff/1/lib/mirrors/mirrors.dart
File lib/mirrors/mirrors.dart (right):

https://chromiumcodereview.appspot.com/10778005/diff/1/lib/mirrors/mirrors.da...
lib/mirrors/mirrors.dart:366: * A formal parameter.
Make this comment look more like others in the file.

/*
 *A [Blah] is a blah.

https://chromiumcodereview.appspot.com/10778005/diff/1/runtime/include/dart_a...
File runtime/include/dart_api.h (right):

https://chromiumcodereview.appspot.com/10778005/diff/1/runtime/include/dart_a...
runtime/include/dart_api.h:2136: int64_t* opt_param_count);
Reindent this function so that Dart_Handle function is on its own line (see
Dart_newWeakPersistentHandle for an example).

https://chromiumcodereview.appspot.com/10778005/diff/1/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://chromiumcodereview.appspot.com/10778005/diff/1/runtime/lib/mirrors.cc...
runtime/lib/mirrors.cc:331: int64_t fixed_param_count, opt_param_count;
We declare only one variable per line.

https://chromiumcodereview.appspot.com/10778005/diff/1/runtime/lib/mirrors.cc...
runtime/lib/mirrors.cc:335: &opt_param_count);
Since parameters are short, reindent like this:

result = Dart_FunctionParameterCounts(func,
                                      &blah,
                                      ....

https://chromiumcodereview.appspot.com/10778005/diff/1/runtime/lib/mirrors.cc...
runtime/lib/mirrors.cc:352: // TODO(rmacnak): Fill parameter mirrors will more
than whether they're opt.
Comment reads funny.  Is there a typo?

https://chromiumcodereview.appspot.com/10778005/diff/1/runtime/lib/mirrors.cc...
runtime/lib/mirrors.cc:356: };
Since there's only one arg, put the initializer and decl all on the same line.

https://chromiumcodereview.appspot.com/10778005/diff/1/runtime/lib/mirrors_im...
File runtime/lib/mirrors_impl.dart (right):

https://chromiumcodereview.appspot.com/10778005/diff/1/runtime/lib/mirrors_im...
runtime/lib/mirrors_impl.dart:414: var _parameters;
Change this var to a type so we get type checking when the constructor is
called.

https://chromiumcodereview.appspot.com/10778005/diff/1/runtime/vm/dart_api_im...
File runtime/vm/dart_api_impl.cc (right):

https://chromiumcodereview.appspot.com/10778005/diff/1/runtime/vm/dart_api_im...
runtime/vm/dart_api_impl.cc:2862: int64_t* opt_param_count) {
Parameters should line up.  Reindent signature as in header file.

https://chromiumcodereview.appspot.com/10778005/diff/1/runtime/vm/dart_api_im...
runtime/vm/dart_api_impl.cc:2879: 
Remove preceding blank line.

https://chromiumcodereview.appspot.com/10778005/diff/1/runtime/vm/dart_api_im...
runtime/vm/dart_api_impl.cc:2880: *fixed_param_count =
func.num_fixed_parameters()
To get this to auto-indent correctly for those using other editors, put parens
around the expression.

Move the minus from the beginning of the 2nd line to the end of the 1st line.

[rmacnak, 2012-07-16 17:36:39]

Addressed comments.

https://chromiumcodereview.appspot.com/10778005/diff/1/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://chromiumcodereview.appspot.com/10778005/diff/1/runtime/lib/mirrors.cc...
runtime/lib/mirrors.cc:356: };
I did that initially, but the linter complained. It isn't complaining now, so
perhaps I was referring to the wrong line number. Anyhow, one-liner now.

On 2012/07/13 23:37:12, turnidge wrote:
> Since there's only one arg, put the initializer and decl all on the same line.

https://chromiumcodereview.appspot.com/10778005/diff/8001/lib/mirrors/mirrors...
File lib/mirrors/mirrors.dart (right):

https://chromiumcodereview.appspot.com/10778005/diff/8001/lib/mirrors/mirrors...
lib/mirrors/mirrors.dart:368: interface ParameterMirror extends VariableMirror {
The members of this interface, copied from the "Reflection in Dart" doc, are all
methods. Perhaps they should be getters, as they should all be quick and
side-effect free?

[turnidge, 2012-07-16 18:30:26]

lgtm, with comments.

Before submitting, be sure to build and test all/all.

Todd

https://chromiumcodereview.appspot.com/10778005/diff/8001/lib/mirrors/mirrors...
File lib/mirrors/mirrors.dart (right):

https://chromiumcodereview.appspot.com/10778005/diff/8001/lib/mirrors/mirrors...
lib/mirrors/mirrors.dart:368: interface ParameterMirror extends VariableMirror {
On 2012/07/16 17:36:39, rmacnak wrote:
> The members of this interface, copied from the "Reflection in Dart" doc, are
all
> methods. Perhaps they should be getters, as they should all be quick and
> side-effect free?

You should probably do whatever *feels* consistent with the rest of this file
(mirrors.dart) as it current stands.  We can go through and mass-change them
later.

[rmacnak, 2012-07-16 22:00:40]

https://chromiumcodereview.appspot.com/10778005/diff/8001/lib/mirrors/mirrors...
File lib/mirrors/mirrors.dart (right):

https://chromiumcodereview.appspot.com/10778005/diff/8001/lib/mirrors/mirrors...
lib/mirrors/mirrors.dart:368: interface ParameterMirror extends VariableMirror {
Okay. I decided to go with getters since its superclass VariableMirror uses
getters.

On 2012/07/16 18:30:26, turnidge wrote:
> On 2012/07/16 17:36:39, rmacnak wrote:
> > The members of this interface, copied from the "Reflection in Dart" doc, are
> all
> > methods. Perhaps they should be getters, as they should all be quick and
> > side-effect free?
> 
> You should probably do whatever *feels* consistent with the rest of this file
> (mirrors.dart) as it current stands.  We can go through and mass-change them
> later.