Add quotes around strings when generating source from the token stream.

Add quotes around strings when generating source from the token stream.
Committed: https://code.google.com/p/dart/source/detail?r=9536

[cshapiro, 2012-07-10 19:03:26]

https://chromiumcodereview.appspot.com/10765017/diff/6001/vm/object.cc
File vm/object.cc (right):

https://chromiumcodereview.appspot.com/10765017/diff/6001/vm/object.cc#newcod...
vm/object.cc:8301: if (str.CharAt(i) == '"') {
This entails one virtual function call per character.  I think the call target
will predicted after a few iterations (provided that the hardware exists), but
it is always more efficient to put this into the per-type cases below.  And,
perhaps, just make each case an instance methods on the 1-, 2- and 4-byte string
classes as we do for other such functions.

https://chromiumcodereview.appspot.com/10765017/diff/6001/vm/object.h
File vm/object.h (right):

https://chromiumcodereview.appspot.com/10765017/diff/6001/vm/object.h#newcode...
vm/object.h:3222: static RawString* EscapeQuotes(const String& str);
I am confused by this method name, possibly because I don't fully understand the
context of this change.

The only quotes being escaped are double quotes.  I do not understand why single
quotes are excluded.  But, since we have 2 distinct classes of quotes and only
one is being escaped, renaming this to EscapeDoubleQuotes makes more sense,
especially in the absence of comments.

https://chromiumcodereview.appspot.com/10765017/diff/6001/vm/snapshot_test.cc
File vm/snapshot_test.cc (right):

https://chromiumcodereview.appspot.com/10765017/diff/6001/vm/snapshot_test.cc...
vm/snapshot_test.cc:771: OS::Print("%s", str.ToCString());
Is this supposed to be here?

[siva, 2012-07-10 22:59:10]

Addressed comments.

PTAL

https://chromiumcodereview.appspot.com/10765017/diff/6001/vm/object.cc
File vm/object.cc (right):

https://chromiumcodereview.appspot.com/10765017/diff/6001/vm/object.cc#newcod...
vm/object.cc:8301: if (str.CharAt(i) == '"') {
On 2012/07/10 19:03:27, cshapiro wrote:
> This entails one virtual function call per character.  I think the call target
> will predicted after a few iterations (provided that the hardware exists), but
> it is always more efficient to put this into the per-type cases below.  And,
> perhaps, just make each case an instance methods on the 1-, 2- and 4-byte
string
> classes as we do for other such functions.

Done.

https://chromiumcodereview.appspot.com/10765017/diff/6001/vm/object.h
File vm/object.h (right):

https://chromiumcodereview.appspot.com/10765017/diff/6001/vm/object.h#newcode...
vm/object.h:3222: static RawString* EscapeQuotes(const String& str);
I will rename this method to EscapeDoubleQuotes.

Only double quotes need to be escaped as I am quoting the strings with double
quotes.

On 2012/07/10 19:03:27, cshapiro wrote:
> I am confused by this method name, possibly because I don't fully understand
the
> context of this change.
> 
> The only quotes being escaped are double quotes.  I do not understand why
single
> quotes are excluded.  But, since we have 2 distinct classes of quotes and only
> one is being escaped, renaming this to EscapeDoubleQuotes makes more sense,
> especially in the absence of comments.

https://chromiumcodereview.appspot.com/10765017/diff/6001/vm/snapshot_test.cc
File vm/snapshot_test.cc (right):

https://chromiumcodereview.appspot.com/10765017/diff/6001/vm/snapshot_test.cc...
vm/snapshot_test.cc:771: OS::Print("%s", str.ToCString());
Removed this line, it was there for verifying what the output looked like.

On 2012/07/10 19:03:27, cshapiro wrote:
> Is this supposed to be here?

[cshapiro, 2012-07-10 23:03:57]

lgtm

lgtm

ship it!