Issue 10758008: - On store buffer block overflow call a VM leaf function to

Issue 10758008: - On store buffer block overflow call a VM leaf function to (Closed)

Created:
8 years, 5 months ago by Ivan Posva

Modified:
8 years, 5 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, cshapiro

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

- On store buffer block overflow call a VM leaf function to add the entries into the store buffer. - Add a way to preserve and restore caller saved registers. - Clean up the implementation of the stub for Assembler::Stop. Committed: https://code.google.com/p/dart/source/detail?r=9490

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Patch Set 4 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+159 lines, -105 lines)			Patch
vm/assembler_ia32.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
vm/assembler_ia32.cc	View	1 2	1 chunk	+14 lines, -0 lines	0 comments	Download
vm/assembler_x64.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
vm/assembler_x64.cc	View	1 2	1 chunk	+30 lines, -0 lines	0 comments	Download
vm/store_buffer.h	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
vm/store_buffer.cc	View	1 2	1 chunk	+18 lines, -2 lines	0 comments	Download
vm/stub_code_ia32.cc	View	1 2	3 chunks	+44 lines, -48 lines	0 comments	Download
vm/stub_code_x64.cc	View	1 2	2 chunks	+41 lines, -55 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://chromiumcodereview.appspot.com/10758008/diff/8001/vm/store_buffer.h File vm/store_buffer.h (right): https://chromiumcodereview.appspot.com/10758008/diff/8001/vm/store_buffer.h#newcode13 vm/store_buffer.h:13: // Forward declarations. https://chromiumcodereview.appspot.com/10758008/diff/8001/vm/stub_code_ia32.cc File vm/stub_code_ia32.cc (right): https://chromiumcodereview.appspot.com/10758008/diff/8001/vm/stub_code_ia32.cc#newcode107 ...

8 years, 5 months ago (2012-07-09 22:51:06 UTC) #2

Ivan Posva

8 years, 5 months ago (2012-07-09 22:59:34 UTC) #3

https://chromiumcodereview.appspot.com/10758008/diff/8001/vm/store_buffer.h
File vm/store_buffer.h (right):

https://chromiumcodereview.appspot.com/10758008/diff/8001/vm/store_buffer.h#n...
vm/store_buffer.h:13: 
On 2012/07/09 22:51:07, asiva wrote:
> // Forward declarations.

Done.

https://chromiumcodereview.appspot.com/10758008/diff/8001/vm/stub_code_ia32.cc
File vm/stub_code_ia32.cc (right):

https://chromiumcodereview.appspot.com/10758008/diff/8001/vm/stub_code_ia32.c...
vm/stub_code_ia32.cc:107: __ ReserveAlignedFrameSpace(kWordSize);
On 2012/07/09 22:51:07, asiva wrote:
> 1 * kWordSize to be uniform with similar code below.

Done.

https://chromiumcodereview.appspot.com/10758008/diff/8001/vm/stub_code_x64.cc
File vm/stub_code_x64.cc (right):

https://chromiumcodereview.appspot.com/10758008/diff/8001/vm/stub_code_x64.cc...
vm/stub_code_x64.cc:109: __ ReserveAlignedFrameSpace(kWordSize);
On 2012/07/09 22:51:07, asiva wrote:
> Nothing is being pushed on the stack as parameters so why not
> __ ReserveAlignedFrameSpace(0);

Done.

Expand Messages | Collapse Messages