support unparsing of "new Object()":

support unparsing of "new Object()":
main() {
  new Object();
}

Committed: https://code.google.com/p/dart/source/detail?r=9496

[Roman, 2012-07-09 16:56:59]

Not sure about this CL. Instantiation of classes requires much deeper
investigation, current changes just tackle this problem.

[Anton Muhin, 2012-07-09 18:31:25]

https://chromiumcodereview.appspot.com/10752002/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/10752002/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:51: if (compilationUnitUri
!== null && compilationUnitUri.path !== null &&
I believe (but not 100% sure) that we have a references to core lib and some
other standard libs, cannot you just do === check on it?

https://chromiumcodereview.appspot.com/10752002/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:64: if
(!shouldOutput(element)) {
nit: single line.

https://chromiumcodereview.appspot.com/10752002/diff/1/tests/compiler/dart2js...
File tests/compiler/dart2js/unparser_test.dart (right):

https://chromiumcodereview.appspot.com/10752002/diff/1/tests/compiler/dart2js...
tests/compiler/dart2js/unparser_test.dart:127: testUnparse('main(){new
Object();}');
sorry, what you stopped to output now, element for Object class?

[Roman, 2012-07-10 03:20:29]

Anton, sorry, but I accidentally used "git cl dcommit" instead of "git cl
upload" and skipped all the confirmations. Here is the commit:
https://code.google.com/p/dart/source/detail?r=9465

If you have any more comments, I'll open a new issue.

https://chromiumcodereview.appspot.com/10752002/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/10752002/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:51: if (compilationUnitUri
!== null && compilationUnitUri.path !== null &&
On 2012/07/09 18:31:26, antonmuhin wrote:
> I believe (but not 100% sure) that we have a references to core lib and some
> other standard libs, cannot you just do === check on it?

Done.
Thanks! Indeed we have reference in compiler. I just grepped for corelib and
found some hacks like mine in tests, that confused me.

https://chromiumcodereview.appspot.com/10752002/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:64: if
(!shouldOutput(element)) {
On 2012/07/09 18:31:26, antonmuhin wrote:
> nit: single line.

Done.

https://chromiumcodereview.appspot.com/10752002/diff/1/tests/compiler/dart2js...
File tests/compiler/dart2js/unparser_test.dart (right):

https://chromiumcodereview.appspot.com/10752002/diff/1/tests/compiler/dart2js...
tests/compiler/dart2js/unparser_test.dart:127: testUnparse('main(){new
Object();}');
On 2012/07/09 18:31:26, antonmuhin wrote:
> sorry, what you stopped to output now, element for Object class?

I don't think I understand the question.

[Anton Muhin, 2012-07-10 06:56:30]

And no worries about accidental commit, please.

https://chromiumcodereview.appspot.com/10752002/diff/1/tests/compiler/dart2js...
File tests/compiler/dart2js/unparser_test.dart (right):

https://chromiumcodereview.appspot.com/10752002/diff/1/tests/compiler/dart2js...
tests/compiler/dart2js/unparser_test.dart:127: testUnparse('main(){new
Object();}');
Sorry, let me rephrase it.

In the description of CL I read "support unparsing of "new Object()":", but in
CL itself I only see that you filter out corelib classes.

So I'd like to understand in details (and ideally update the description,
although it's probably too late right now), why this change helps us to unparsr
constructs like new Object?

Is it because now we shouldn't now care about elements corresponding to classes
in corelib?

On 2012/07/10 03:20:29, Roman wrote:
> On 2012/07/09 18:31:26, antonmuhin wrote:
> > sorry, what you stopped to output now, element for Object class?
> 
> I don't think I understand the question.