Issue 10749014: Refactor Source to take the system cache as a parameter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10749014: Refactor Source to take the system cache as a parameter. (Closed)

Created:
8 years, 5 months ago by nweiz

Modified:
8 years, 5 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Refactor Source to take the system cache as a parameter. Committed: https://code.google.com/p/dart/source/detail?r=9519

Patch Set 2 : Merge #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -11 lines)			Patch
M	utils/pub/pub.dart	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	utils/pub/repo_source.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	utils/pub/source.dart	View		3 chunks	+37 lines, -4 lines	0 comments	Download
M	utils/pub/system_cache.dart	View		3 chunks	+11 lines, -2 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

One tiny nit. LGTM! https://chromiumcodereview.appspot.com/10749014/diff/2001/utils/pub/system_cache.dart File utils/pub/system_cache.dart (right): https://chromiumcodereview.appspot.com/10749014/diff/2001/utils/pub/system_cache.dart#newcode44 utils/pub/system_cache.dart:44: * Registers a new source. ...

8 years, 5 months ago (2012-07-10 16:12:36 UTC) #2

nweiz

8 years, 5 months ago (2012-07-10 18:13:01 UTC) #3

https://chromiumcodereview.appspot.com/10749014/diff/2001/utils/pub/system_ca...
File utils/pub/system_cache.dart (right):

https://chromiumcodereview.appspot.com/10749014/diff/2001/utils/pub/system_ca...
utils/pub/system_cache.dart:44: * Registers a new source. This source may not
have the same name as a source
On 2012/07/10 16:12:36, Bob Nystrom wrote:
> "may" -> "must"

Done.

Expand Messages | Collapse Messages

Issue 10749014: Refactor Source to take the system cache as a parameter. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Merge #

Messages