Issue 10741002: Replace 'NativeTraits' typedef with 'isNode', 'isActive', and 'isEventTarget' static boolean fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10741002: Replace 'NativeTraits' typedef with 'isNode', 'isActive', and 'isEventTarget' static boolean fields. (Closed)

Created:
8 years, 5 months ago by podivilov

Modified:
8 years, 5 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Replace 'NativeTraits' typedef with 'isNode', 'isActive', and 'isEventTarget' static boolean fields. 'isEventTarget' field is needed to implement proper GC semantics for non-node event target listeners. 'isNode'+'isActive' is a direct replacement of 'NativeTraits' typedef. R=antonm@google.com Committed: https://code.google.com/p/dart/source/detail?r=9501

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -20 lines)			Patch
	M	lib/dom/scripts/systemnative.py	View	1	2 chunks	+14 lines, -19 lines	0 comments	Download
	M	lib/dom/templates/dom/native/cpp_header.template	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

lgtm, but we have DartDOMStringMap.h purely in custom bindings, might be worth unification. https://chromiumcodereview.appspot.com/10741002/diff/1/lib/dom/scripts/systemnative.py File ...

8 years, 5 months ago (2012-07-09 15:22:43 UTC) #2

podivilov

8 years, 5 months ago (2012-07-10 10:51:13 UTC) #3

https://chromiumcodereview.appspot.com/10741002/diff/1/lib/dom/scripts/system...
File lib/dom/scripts/systemnative.py (right):

https://chromiumcodereview.appspot.com/10741002/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemnative.py:425: is_node_checker = lambda interface:
interface.id == 'Node'
On 2012/07/09 15:22:43, antonmuhin wrote:
> nit: _test instead of _checker?

Done.

https://chromiumcodereview.appspot.com/10741002/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemnative.py:953: def _FindInHierarchy(database, interface,
checker):
On 2012/07/09 15:22:43, antonmuhin wrote:
> ditto for test

Done.

Expand Messages | Collapse Messages