Issue 10736015: Make the Git source install to the system cache.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10736015: Make the Git source install to the system cache. (Closed)

Created:
8 years, 5 months ago by nweiz

Modified:
8 years, 5 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make the Git source install to the system cache. Committed: https://code.google.com/p/dart/source/detail?r=9527

Patch Set 1 #

Patch Set 2 : Minor fixes #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+283 lines, -29 lines)			Patch
M	utils/pub/git_source.dart	View	1	3 chunks	+91 lines, -15 lines	1 comment	Download
M	utils/pub/source.dart	View		1 chunk	+29 lines, -2 lines	0 comments	Download
M	utils/pub/system_cache.dart	View		1 chunk	+1 line, -12 lines	0 comments	Download
M	utils/pub/utils.dart	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	utils/tests/pub/pub_test.dart	View		3 chunks	+154 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

8 years, 5 months ago (2012-07-10 21:29:33 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10736015/diff/2001/utils/pub/git_sourc...
File utils/pub/git_source.dart (right):

https://chromiumcodereview.appspot.com/10736015/diff/2001/utils/pub/git_sourc...
utils/pub/git_source.dart:35: * in `cache/`.
Nice comment!

Expand Messages | Collapse Messages