Issue 3986. Class member cannot have the same name as the class

Issue 3986. Class member cannot have the same name as the class
http://code.google.com/p/dart/issues/detail?id=3986


R=brianwilkerson@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=9577

[Brian Wilkerson, 2012-07-11 14:54:15]

LGTM, with or without addressing my comments.

https://chromiumcodereview.appspot.com/10735039/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java
(right):

https://chromiumcodereview.appspot.com/10735039/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java:152:
MEMBER_WITH_NAME_OF_CLASS("Class member should not have same name as the
enclosing class"),
nit: "same" --> "the same"

https://chromiumcodereview.appspot.com/10735039/diff/1/compiler/javatests/com...
File
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java
(right):

https://chromiumcodereview.appspot.com/10735039/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java:1317:
public void test_memberWithNameOfClass() throws Exception {
Consider adding tests for static members. Also, the original case used the
"abstract" modifier to force a member to be parsed as a method rather than a
constructor, which might make C a better test of this issue (given that right
now it's testing a different error case).