Issue 10735002: Add support for fixed parameters in SSA builder and fix a bug in the pre-order graph traversal.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10735002: Add support for fixed parameters in SSA builder and fix a bug in the pre-order graph traversal. (Closed)

Created:
8 years, 5 months ago by Florian Schneider

Modified:
8 years, 5 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Add support for fixed parameters in SSA builder and fix a bug in the pre-order graph traversal. Each fixed parameter is initially defined by a ParameterInstr as definition. This definition is not in the instruction stream, but just in the initial environment at the graph entry so that the live range of all parameters start at the same point. The pre-order spanning tree was computed in the wrong way which caused test failures when building SSA because renaming relies on the dominator tree which depends on the preorder spanning tree. Also change the IL printing functions to be more compatible with the visualizer tool. Committed: https://code.google.com/p/dart/source/detail?r=9391

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -33 lines)			Patch
M	vm/flow_graph_builder.cc	View	1	2 chunks	+21 lines, -13 lines	0 comments	Download
M	vm/il_printer.cc	View		10 chunks	+24 lines, -12 lines	0 comments	Download
M	vm/intermediate_language.h	View		3 chunks	+20 lines, -4 lines	0 comments	Download
M	vm/intermediate_language.cc	View		2 chunks	+19 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages