Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 10716005: Fixes the scope of case labels so that duplicate case labels are properly detected (Closed)

Created:
8 years, 5 months ago by zundel
Modified:
8 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, scheglov
Visibility:
Public.

Description

Fixes the scope of case labels so that duplicate case labels are properly detected Issue 2441 http://code.google.com/p/dart/issues/detail?id=2441 Committed: https://code.google.com/p/dart/source/detail?r=9200

Patch Set 1 : # #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -10 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/Resolver.java View 2 chunks +15 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Scope.java View 2 chunks +14 lines, -3 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java View 4 chunks +15 lines, -3 lines 0 comments Download
M tests/co19/co19-compiler.status View 1 chunk +2 lines, -4 lines 0 comments Download
M tests/language/language.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
zundel
8 years, 5 months ago (2012-06-28 13:59:42 UTC) #1
Brian Wilkerson
8 years, 5 months ago (2012-06-28 14:21:25 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698