Issue 10704219: Handle all registered types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10704219: Handle all registered types. (Closed)

Created:
8 years, 5 months ago by sra1

Modified:
8 years, 5 months ago

Reviewers:
podivilov, podivilov1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle all registered types, not just 'Primitive' ones. This change preserves the name through to the generated C++ code. Committed: https://code.google.com/p/dart/source/detail?r=9688

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -33 lines)			Patch
M	lib/dom/dom.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	lib/dom/frog/dom_frog.dart	View		2 chunks	+1 line, -5 lines	0 comments	Download
M	lib/dom/scripts/dartgenerator.py	View	1	1 chunk	+6 lines, -3 lines	0 comments	Download
M	lib/dom/scripts/generator.py	View	1	3 chunks	+6 lines, -5 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		2 chunks	+1 line, -12 lines	0 comments	Download
M	lib/html/frog/html_frog.dart	View		2 chunks	+1 line, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sra1

Hi Pavel, Is this the right way to propagate the type 'MutationRecordArray' through to the ...

8 years, 5 months ago (2012-07-14 02:34:47 UTC) #1

podivilov

8 years, 5 months ago (2012-07-16 10:25:12 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10704219/diff/1/lib/dom/scripts/dartge...
File lib/dom/scripts/dartgenerator.py (right):

https://chromiumcodereview.appspot.com/10704219/diff/1/lib/dom/scripts/dartge...
lib/dom/scripts/dartgenerator.py:54: return self._IsCompoundType(database,
type_name[:-len('Array')])
This is fragile, could you please rename IsPrimitiveType to IsRegistredType and
remove _idl_type_registry[type_name].clazz == 'Primitive' check from it?

https://chromiumcodereview.appspot.com/10704219/diff/1/lib/dom/scripts/genera...
File lib/dom/scripts/generator.py (right):

https://chromiumcodereview.appspot.com/10704219/diff/1/lib/dom/scripts/genera...
lib/dom/scripts/generator.py:806: 'MutationRecordArray':
TypeData(clazz='Interface',  # C++ pass by pointer.
Please move to interfaces block above.

Expand Messages | Collapse Messages