Fix type checking of void type.

Fix type checking of void type.
Fix library and tests accordingly.
Add new test.
Disable new test for dart2js.
Disable some now failing co19 tests (new issue 158 filed).
Hide internal VM String types from user (not complete).
Committed: https://code.google.com/p/dart/source/detail?r=9672

[srdjan, 2012-07-16 15:21:11]

LGTM with one question. Maybe it would be worth it to send a separate email to
dart-team saying that the error reporting is now tighter, and that error can be
expected if code is wrong.

https://chromiumcodereview.appspot.com/10704216/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_compiler_ia32.cc (right):

https://chromiumcodereview.appspot.com/10704216/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_compiler_ia32.cc:425: return SubtypeTestCache::null();
When can the type we check agains be void?

[siva, 2012-07-16 16:41:33]

LGTM with one comment regarding setter methods of byte array, I believe they
need to return the offset of the first byte in the array after the byte that was
set by the call.

https://chromiumcodereview.appspot.com/10704216/diff/1/runtime/lib/byte_array.cc
File runtime/lib/byte_array.cc (right):

https://chromiumcodereview.appspot.com/10704216/diff/1/runtime/lib/byte_array...
runtime/lib/byte_array.cc:65: ByteArray::Copy(array, index.Value(), &src,
sizeof(ValueT));
I think the setter methods of byte array need to return a value, they are not
'void'.

https://chromiumcodereview.appspot.com/10704216/diff/1/runtime/lib/byte_array...
runtime/lib/byte_array.cc:124: ByteArray::Copy(array, index.Value(), &value,
sizeof(uint64_t));
Ditto.

[regis, 2012-07-16 18:05:34]

Thanks!

I'll send a heads up email, as suggested.

-- Regis

https://chromiumcodereview.appspot.com/10704216/diff/1/runtime/lib/byte_array.cc
File runtime/lib/byte_array.cc (right):

https://chromiumcodereview.appspot.com/10704216/diff/1/runtime/lib/byte_array...
runtime/lib/byte_array.cc:65: ByteArray::Copy(array, index.Value(), &src,
sizeof(ValueT));
On 2012/07/16 16:41:33, asiva wrote:
> I think the setter methods of byte array need to return a value, they are not
> 'void'.

Good point! I reverted the change here and instead modified the dart version to
return an int.

https://chromiumcodereview.appspot.com/10704216/diff/1/runtime/lib/byte_array...
runtime/lib/byte_array.cc:124: ByteArray::Copy(array, index.Value(), &value,
sizeof(uint64_t));
On 2012/07/16 16:41:33, asiva wrote:
> Ditto.

Done.

https://chromiumcodereview.appspot.com/10704216/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_compiler_ia32.cc (right):

https://chromiumcodereview.appspot.com/10704216/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_compiler_ia32.cc:425: return SubtypeTestCache::null();
On 2012/07/16 15:21:12, srdjan wrote:
> When can the type we check agains be void?

When we type check a value returned from a void function. Note that we will not
reach here if the returned value is null, since this case is handled by the
inlined code. So this case will result in a type error.
I have added a comment.
Remember also that this helper is used in both 'instance of' and 'check
assignable'.