Issue 10704210: Fix problem of excessive attempts to optimize, fix excessive deoptimizations for load/store indexed…

Issue 10704210: Fix problem of excessive attempts to optimize, fix excessive deoptimizations for load/store indexed… (Closed)

Created:
8 years, 5 months ago by srdjan

Modified:
8 years, 5 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix problem of excessive attempts to optimize, fix excessive deoptimizations for load/store indexed, performance issue with non-inlineable instance setter (direct call instead of IC call). Add tracing of issues encountered when attepting to optimize a method (--trace_failed_optimization_attempts), rename flag --print_stacktrace_at_throw. Committed: https://code.google.com/p/dart/source/detail?r=9680

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 2

Patch Set 6 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+219 lines, -79 lines)			Patch
M	runtime/vm/code_generator.h	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View	1 2 3 4 5	5 chunks	+44 lines, -13 lines	0 comments	Download
M	runtime/vm/exceptions.cc	View	1 2 3 4 5	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2 3 4 5	1 chunk	+2 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2 3 4 5	7 chunks	+80 lines, -27 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2 3 4 5	7 chunks	+80 lines, -27 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1 2 3 4 5	2 chunks	+4 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1 2 3 4 5	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10704210/diff/8003/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://chromiumcodereview.appspot.com/10704210/diff/8003/runtime/vm/code_generator.cc#newcode27 runtime/vm/code_generator.cc:27: DEFINE_FLAG(bool, trace_ic, false, "trace IC handling"); trace -> ...

8 years, 5 months ago (2012-07-16 17:05:33 UTC) #2

srdjan

8 years, 5 months ago (2012-07-16 20:36:29 UTC) #3

https://chromiumcodereview.appspot.com/10704210/diff/8003/runtime/vm/code_gen...
File runtime/vm/code_generator.cc (right):

https://chromiumcodereview.appspot.com/10704210/diff/8003/runtime/vm/code_gen...
runtime/vm/code_generator.cc:27: DEFINE_FLAG(bool, trace_ic, false, "trace IC
handling");
On 2012/07/16 17:05:33, regis wrote:
> trace -> Trace

Done.

Expand Messages | Collapse Messages