Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10704180: Use 'int' instead of Position. (Closed)

Created:
8 years, 5 months ago by scheglov
Modified:
8 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use 'int' instead of Position. By doing so we get 5-7% of performance in running JUnit tests. R=brianwilkerson@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9596

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -263 lines) Patch
M compiler/java/com/google/dart/compiler/DartCompilationError.java View 2 chunks +5 lines, -14 lines 1 comment Download
M compiler/java/com/google/dart/compiler/common/SourceInfo.java View 1 chunk +3 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/parser/AbstractParser.java View 3 chunks +9 lines, -10 lines 0 comments Download
M compiler/java/com/google/dart/compiler/parser/CompletionHooksParserBase.java View 1 chunk +1 line, -1 line 1 comment Download
M compiler/java/com/google/dart/compiler/parser/DartParser.java View 16 chunks +19 lines, -20 lines 0 comments Download
M compiler/java/com/google/dart/compiler/parser/DartParserCommentsHelper.java View 1 chunk +1 line, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/parser/DartScanner.java View 20 chunks +47 lines, -133 lines 0 comments Download
M compiler/java/com/google/dart/compiler/parser/DartScannerParserContext.java View 4 chunks +9 lines, -9 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/PrettyErrorFormatterTest.java View 11 chunks +12 lines, -11 lines 1 comment Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/NodeFinder.java View 1 chunk +1 line, -1 line 1 comment Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionParser.java View 4 chunks +4 lines, -6 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/dom/rewrite/TokenScanner.java View 2 chunks +2 lines, -2 lines 1 comment Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/formatter/Scanner.java View 4 chunks +47 lines, -47 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartAutoIndentStrategy.java View 1 chunk +3 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/folding/DefaultDartFoldingStructureProvider.java View 3 chunks +5 lines, -5 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 5 months ago (2012-07-12 05:40:47 UTC) #1
Brian Wilkerson
8 years, 5 months ago (2012-07-12 15:35:11 UTC) #2 
LGTM

https://chromiumcodereview.appspot.com/10704180/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/DartCompilationError.java (right):

https://chromiumcodereview.appspot.com/10704180/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/DartCompilationError.java:1: // Copyright
(c) 2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

https://chromiumcodereview.appspot.com/10704180/diff/1/compiler/java/com/goog...
File
compiler/java/com/google/dart/compiler/parser/CompletionHooksParserBase.java
(right):

https://chromiumcodereview.appspot.com/10704180/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/parser/CompletionHooksParserBase.java:1:
// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

https://chromiumcodereview.appspot.com/10704180/diff/1/compiler/javatests/com...
File compiler/javatests/com/google/dart/compiler/PrettyErrorFormatterTest.java
(right):

https://chromiumcodereview.appspot.com/10704180/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/PrettyErrorFormatterTest.java:1: //
Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
nit: copyright year

https://chromiumcodereview.appspot.com/10704180/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/NodeFinder.java
(right):

https://chromiumcodereview.appspot.com/10704180/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/dom/NodeFinder.java:2:
* Copyright (c) 2011, the Dart project authors.
nit: copyright year

https://chromiumcodereview.appspot.com/10704180/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/dom/rewrite/TokenScanner.java
(right):

https://chromiumcodereview.appspot.com/10704180/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/dom/rewrite/TokenScanner.java:2:
* Copyright (c) 2011, the Dart project authors.
nit: copyright year

https://chromiumcodereview.appspot.com/10704180/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/folding/DefaultDartFoldingStructureProvider.java
(right):

https://chromiumcodereview.appspot.com/10704180/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/folding/DefaultDartFoldingStructureProvider.java:2:
* Copyright (c) 2011, the Dart project authors.
nit: copyright year

Powered by Google App Engine
This is Rietveld 408576698