Issue 10704108: Use computed field types to recompile methods containing binary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10704108: Use computed field types to recompile methods containing binary (Closed)

Created:
8 years, 5 months ago by Mads Ager (google)

Modified:
8 years, 5 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use computed field types to recompile methods containing binary arithmetic on contants and (suspected) number fields. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9429

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove stray 'print' #

Patch Set 3 : Refactor based on review comment. #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -28 lines)			Patch
	M	lib/compiler/implementation/ssa/optimize.dart	View	1 2	2 chunks	+88 lines, -28 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://chromiumcodereview.appspot.com/10704108/diff/1/lib/compiler/implementation/ssa/optimize.dart File lib/compiler/implementation/ssa/optimize.dart (right): https://chromiumcodereview.appspot.com/10704108/diff/1/lib/compiler/implementation/ssa/optimize.dart#newcode1260 lib/compiler/implementation/ssa/optimize.dart:1260: HInstruction other; Maybe we can also do like ...

8 years, 5 months ago (2012-07-06 08:38:43 UTC) #2

Mads Ager (google)

8 years, 5 months ago (2012-07-06 08:42:18 UTC) #3

https://chromiumcodereview.appspot.com/10704108/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/optimize.dart (right):

https://chromiumcodereview.appspot.com/10704108/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/optimize.dart:1260: HInstruction other;
On 2012/07/06 08:38:43, Søren Gjesse wrote:
> Maybe we can also do like this field/other stuff in the visitEquals above
> (currently it requires the rhs to be a constant).

Yes, let me do that as well. I will pull the conflicting check in equals to
before the switch as well.

Expand Messages | Collapse Messages