Issue 10704008: Make HtmlFrogSystem and NativeImplementationSystem the backends for HtmlInterfacesSystem and remove…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10704008: Make HtmlFrogSystem and NativeImplementationSystem the backends for HtmlInterfacesSystem and remove… (Closed)

Created:
8 years, 5 months ago by podivilov

Modified:
8 years, 5 months ago

Reviewers:
Anton Muhin, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make HtmlFrogSystem and NativeImplementationSystem the backends for HtmlInterfacesSystem and remove HtmlDartiumSystem. This will allow easy code reuse between all existing html systems. R=antonm@google.com,sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=9240

Patch Set 1 #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -104 lines)			Patch
M	lib/dom/scripts/dartdomgenerator.py	View	3 chunks	+41 lines, -50 lines	2 comments	Download
M	lib/dom/scripts/dartgenerator.py	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/dom/scripts/systembase.py	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	lib/dom/scripts/systemfrog.py	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/dom/scripts/systemhtml.py	View	4 chunks	+8 lines, -44 lines	0 comments	Download
M	lib/dom/scripts/systemnative.py	View	3 chunks	+11 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

lgtm https://chromiumcodereview.appspot.com/10704008/diff/1/lib/dom/scripts/dartdomgenerator.py File lib/dom/scripts/dartdomgenerator.py (right): https://chromiumcodereview.appspot.com/10704008/diff/1/lib/dom/scripts/dartdomgenerator.py#newcode70 lib/dom/scripts/dartdomgenerator.py:70: systems = [] is it used?

8 years, 5 months ago (2012-06-27 19:06:28 UTC) #2

podivilov

8 years, 5 months ago (2012-06-29 10:01:52 UTC) #3

https://chromiumcodereview.appspot.com/10704008/diff/1/lib/dom/scripts/dartdo...
File lib/dom/scripts/dartdomgenerator.py (right):

https://chromiumcodereview.appspot.com/10704008/diff/1/lib/dom/scripts/dartdo...
lib/dom/scripts/dartdomgenerator.py:70: systems = []
On 2012/06/27 19:06:28, antonmuhin wrote:
> is it used?

Done.

Expand Messages | Collapse Messages