Extract interfaces and members renaming logic to a new HtmlRenamer class.

Extract interfaces and members renaming logic to a new HtmlRenamer class.


R=antonm@google.com,sra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=9660

[Anton Muhin, 2012-07-16 10:27:03]

https://chromiumcodereview.appspot.com/10703194/diff/1/lib/dom/scripts/databa...
File lib/dom/scripts/database.py (right):

https://chromiumcodereview.appspot.com/10703194/diff/1/lib/dom/scripts/databa...
lib/dom/scripts/database.py:229: def FindInHierarchy(self, interface, test):
I'd rather implement it as Python's generator, something like: def Hirarchty():
  for parent in interface.parents:
    yield parent
    for p in _Hierachy(parent):
      yield p

And now you can write any(test, database._Hieratchy(interface))

https://chromiumcodereview.appspot.com/10703194/diff/1/lib/dom/scripts/htmlre...
File lib/dom/scripts/htmlrenamer.py (right):

https://chromiumcodereview.appspot.com/10703194/diff/1/lib/dom/scripts/htmlre...
lib/dom/scripts/htmlrenamer.py:277: if interface.id[6:] in
_html_strip_webkit_prefix_classes:
[len('WebKit'):] instead 6?  Overall, it might be time to introduce helper
functions to strip prefix and suffix.

[podivilov, 2012-07-16 12:08:36]

https://chromiumcodereview.appspot.com/10703194/diff/1/lib/dom/scripts/databa...
File lib/dom/scripts/database.py (right):

https://chromiumcodereview.appspot.com/10703194/diff/1/lib/dom/scripts/databa...
lib/dom/scripts/database.py:229: def FindInHierarchy(self, interface, test):
On 2012/07/16 10:27:04, Anton Mukhin wrote:
> I'd rather implement it as Python's generator, something like: def
Hirarchty():
>   for parent in interface.parents:
>     yield parent
>     for p in _Hierachy(parent):
>       yield p
> 
> And now you can write any(test, database._Hieratchy(interface))

Done.

https://chromiumcodereview.appspot.com/10703194/diff/1/lib/dom/scripts/htmlre...
File lib/dom/scripts/htmlrenamer.py (right):

https://chromiumcodereview.appspot.com/10703194/diff/1/lib/dom/scripts/htmlre...
lib/dom/scripts/htmlrenamer.py:277: if interface.id[6:] in
_html_strip_webkit_prefix_classes:
On 2012/07/16 10:27:04, Anton Mukhin wrote:
> [len('WebKit'):] instead 6? 

Done.

> Overall, it might be time to introduce helper
> functions to strip prefix and suffix.

Personally, I don't feel like introducing helpers would make this code better.

[Anton Muhin, 2012-07-16 12:16:22]

lgtm