Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 10703188: Allow patch files to add top-level declarations to the patched library. (Closed)

Created:
8 years, 5 months ago by Lasse Reichstein Nielsen
Modified:
8 years, 4 months ago
CC:
reviews_dartlang.org, ahe
Visibility:
Public.

Description

Allow patch files to add top-level declarations to the patched library. The patch library is loaded normally, and then non-patch methods and classes are cloned and added to the patched library. To support methods from other compilation units, all elements now has a scriptOverride field that lets them report a different script than the one of their enclosing element. (For top-level elements that's already possible, as that's what #source does, but for fields inside a class, we can't easily wrap a compilation unit element around them.) TBR: floitsch (to get in before vacation, with reversion rights). Committed: https://code.google.com/p/dart/source/detail?r=9629

Patch Set 1 #

Patch Set 2 : Updated min/max in unified/math library. #

Total comments: 4

Patch Set 3 : Fix errors caught by editor. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+292 lines, -105 lines) Patch
M corelib/unified/math/base.dart View 1 1 chunk +65 lines, -10 lines 0 comments Download
M corelib/unified/math/random.dart View 3 chunks +5 lines, -12 lines 0 comments Download
M lib/compiler/implementation/compiler.dart View 1 2 5 chunks +25 lines, -48 lines 0 comments Download
M lib/compiler/implementation/elements/elements.dart View 1 2 19 chunks +133 lines, -16 lines 0 comments Download
M lib/compiler/implementation/lib/math.dartp View 3 chunks +17 lines, -9 lines 0 comments Download
M lib/compiler/implementation/patch_parser.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/compiler/implementation/resolver.dart View 1 chunk +1 line, -2 lines 0 comments Download
M lib/compiler/implementation/scanner/class_element_parser.dart View 3 chunks +14 lines, -3 lines 0 comments Download
M lib/compiler/implementation/scanner/listener.dart View 1 2 3 chunks +27 lines, -0 lines 0 comments Download
M lib/compiler/implementation/scanner/scanner_task.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M lib/compiler/implementation/ssa/codegen.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/unparse_validator.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
https://chromiumcodereview.appspot.com/10703188/diff/2001/lib/compiler/implementation/elements/elements.dart File lib/compiler/implementation/elements/elements.dart (right): https://chromiumcodereview.appspot.com/10703188/diff/2001/lib/compiler/implementation/elements/elements.dart#newcode1060 lib/compiler/implementation/elements/elements.dart:1060: target.type = type; We should consider whether copying these ...
8 years, 5 months ago (2012-07-13 11:17:09 UTC) #1
Lasse Reichstein Nielsen
8 years, 5 months ago (2012-07-13 12:49:09 UTC) #2
floitsch
LGTM. https://chromiumcodereview.appspot.com/10703188/diff/2001/lib/compiler/implementation/elements/elements.dart File lib/compiler/implementation/elements/elements.dart (right): https://chromiumcodereview.appspot.com/10703188/diff/2001/lib/compiler/implementation/elements/elements.dart#newcode420 lib/compiler/implementation/elements/elements.dart:420: PrefixElement cloneTo(Element enclosing, DiagnosticListener listener) { move closer ...
8 years, 5 months ago (2012-07-17 11:06:51 UTC) #3
Anders Johnsen
8 years, 4 months ago (2012-08-02 15:19:23 UTC) #4

          

Powered by Google App Engine
This is Rietveld 408576698