Issue 10703105: Print out browser version for the autoupdating browsers (ff and chrome) on

Issue 10703105: Print out browser version for the autoupdating browsers (ff and chrome) on (Closed)

Created:
8 years, 5 months ago by Emily Fortuna

Modified:
8 years, 5 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, sra1

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Print out browser version for the autoupdating browsers (ff and chrome) on buildbot trace. Committed: https://code.google.com/p/dart/source/detail?r=9440

Patch Set 1 : #

Total comments: 6

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -6 lines)			Patch
	M	utils/compiler/buildbot.py	View		7 chunks	+41 lines, -6 lines	6 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

small change to make our browser test debugging more informative.

8 years, 5 months ago (2012-07-06 12:51:35 UTC) #1

kasperl

LGTM. https://chromiumcodereview.appspot.com/10703105/diff/2001/utils/compiler/buildbot.py File utils/compiler/buildbot.py (right): https://chromiumcodereview.appspot.com/10703105/diff/2001/utils/compiler/buildbot.py#newcode181 utils/compiler/buildbot.py:181: - is_builbot: true if we are running on ...

8 years, 5 months ago (2012-07-06 12:56:54 UTC) #2

Emily Fortuna

8 years, 5 months ago (2012-07-06 13:03:19 UTC) #3

https://chromiumcodereview.appspot.com/10703105/diff/2001/utils/compiler/buil...
File utils/compiler/buildbot.py (right):

https://chromiumcodereview.appspot.com/10703105/diff/2001/utils/compiler/buil...
utils/compiler/buildbot.py:181: - is_builbot: true if we are running on a real
buildbot instead of
On 2012/07/06 12:56:55, kasperl wrote:
> is_builbot -> is_buildbot

Done.

https://chromiumcodereview.appspot.com/10703105/diff/2001/utils/compiler/buil...
utils/compiler/buildbot.py:209: 'ff': mac_path % (partDict[runtime],
On 2012/07/06 12:56:55, kasperl wrote:
> Weird indentation. 4 spaces instead?

Right. Not sure what happened there. fixed!

https://chromiumcodereview.appspot.com/10703105/diff/2001/utils/compiler/buil...
utils/compiler/buildbot.py:223: # Print out browser version numbers if we're
running on the builbot (where
On 2012/07/06 12:56:55, kasperl wrote:
> builbot -> buildbot

Done.

Expand Messages | Collapse Messages