Issue 10703087: Ignore setters in constructors when evaluating determining firect field access

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10703087: Ignore setters in constructors when evaluating determining firect field access (Closed)

Created:
8 years, 5 months ago by Søren Gjesse

Modified:
8 years, 5 months ago

Reviewers:
floitsch, Mads Ager (google), ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Ignore setters in constructors when evaluating determining firect field access Setters in constructors cannot mutate an object after construction. Doesen't do much for preformance but simplifies some of the generated code and shakes out a few getters. R=floitsch@google.com, ager@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9386

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	lib/compiler/implementation/ssa/codegen.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Very nice!

Expand Messages | Collapse Messages