Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 10703030: Get rid of BidiUtils as a class holding only static methods. I was reminded by (Closed)

Created:
8 years, 5 months ago by Emily Fortuna
Modified:
8 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Get rid of BidiUtils as a class holding only static methods. I was reminded by this dart style quiz (third slide: http://data-prez.appspot.com/deck/id=agtzfmRhdGEtcHJlenIRCxIJU2xpZGVEZWNrGKm6BAw&slide=2?locale=en). Committed: https://code.google.com/p/dart/source/detail?r=9222

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+423 lines, -432 lines) Patch
M lib/i18n/bidi_formatter.dart View 4 chunks +7 lines, -9 lines 0 comments Download
M lib/i18n/bidi_utils.dart View 1 chunk +305 lines, -307 lines 0 comments Download
M tests/lib/i18n/bidi_format_test.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/lib/i18n/bidi_utils_test.dart View 3 chunks +111 lines, -111 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Emily Fortuna
I was taking that dart style quiz, and was reminded that I shouldn't have a ...
8 years, 5 months ago (2012-06-28 17:54:03 UTC) #1
Bob Nystrom
I'm assuming this is just hoisting stuff to the top level, so I didn't read ...
8 years, 5 months ago (2012-06-28 18:09:19 UTC) #2
Alan Knight
8 years, 5 months ago (2012-06-28 18:29:21 UTC) #3
Apparently these sorts of changes are deeply confusing for the differencing
algorithm. LGTM.

Powered by Google App Engine
This is Rietveld 408576698