Issue 10703004: Update status file and fix a "static inheritance" bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10703004: Update status file and fix a "static inheritance" bug. (Closed)

Created:
8 years, 5 months ago by ahe

Modified:
8 years, 5 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Update status file and fix a "static inheritance" bug. Committed: https://code.google.com/p/dart/source/detail?r=9156

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -4 lines)			Patch
M	dart/samples/tests/samples/samples.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	dart/samples/ui_lib/layout/GridLayoutParser.dart	View	1 chunk	+1 line, -1 line	1 comment	Download
M	dart/tests/co19/co19-leg.status	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	dart/tests/language/language.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ahe

Submitted TBR to make the build green. https://chromiumcodereview.appspot.com/10703004/diff/1/dart/samples/ui_lib/layout/GridLayoutParser.dart File dart/samples/ui_lib/layout/GridLayoutParser.dart (right): https://chromiumcodereview.appspot.com/10703004/diff/1/dart/samples/ui_lib/layout/GridLayoutParser.dart#newcode380 dart/samples/ui_lib/layout/GridLayoutParser.dart:380: if (_peekChar() ...

8 years, 5 months ago (2012-06-27 10:44:02 UTC) #1

LGTM

Expand Messages | Collapse Messages