Introduce TypeRegistry class.

Introduce TypeRegistry class.

This is needed to optionally associate additional state like html renames
map with IDLTypeInfo instances.

R=antonm@google.com,sra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=9634

[Anton Muhin, 2012-07-13 15:18:55]

https://chromiumcodereview.appspot.com/10702202/diff/1/lib/dom/scripts/dartdo...
File lib/dom/scripts/dartdomgenerator.py (right):

https://chromiumcodereview.appspot.com/10702202/diff/1/lib/dom/scripts/dartdo...
lib/dom/scripts/dartdomgenerator.py:65: def
CreateGeneratorContext(template_paths, conditions, output_dir):
context is somewhat too broad the word, may we have something more specific?

https://chromiumcodereview.appspot.com/10702202/diff/1/lib/dom/scripts/genera...
File lib/dom/scripts/generator.py (right):

https://chromiumcodereview.appspot.com/10702202/diff/1/lib/dom/scripts/genera...
lib/dom/scripts/generator.py:498: self.__dict__['_' + p] = data.get(p, None)
I wonder if it's semantically ok: when _-mangling is performed?  do you need _
at all?

https://chromiumcodereview.appspot.com/10702202/diff/1/lib/dom/scripts/genera...
lib/dom/scripts/generator.py:727: _idl_type_registry_properties = [
as another option.

class TypeData(object):
  def __init__(self,
    dart_type=None,
    native_type = None,
    ...):
  self._dart_type = dart_type
  ...

now you'll have 'byte': TypeInfo(type='Primitive', dart_type='bool', ...)

which is more readable imho and requires no black magic.

https://chromiumcodereview.appspot.com/10702202/diff/1/lib/dom/scripts/system...
File lib/dom/scripts/systembase.py (right):

https://chromiumcodereview.appspot.com/10702202/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systembase.py:225: class GeneratorContext(object):
GeneratorOptions?  GeneratorParameters?  Context is too broad imho

[podivilov, 2012-07-13 16:05:21]

PTAL.

https://chromiumcodereview.appspot.com/10702202/diff/1/lib/dom/scripts/dartdo...
File lib/dom/scripts/dartdomgenerator.py (right):

https://chromiumcodereview.appspot.com/10702202/diff/1/lib/dom/scripts/dartdo...
lib/dom/scripts/dartdomgenerator.py:65: def
CreateGeneratorContext(template_paths, conditions, output_dir):
On 2012/07/13 15:18:55, Anton Mukhin wrote:
> context is somewhat too broad the word, may we have something more specific?

Done.

https://chromiumcodereview.appspot.com/10702202/diff/1/lib/dom/scripts/genera...
File lib/dom/scripts/generator.py (right):

https://chromiumcodereview.appspot.com/10702202/diff/1/lib/dom/scripts/genera...
lib/dom/scripts/generator.py:498: self.__dict__['_' + p] = data.get(p, None)
On 2012/07/13 15:18:55, Anton Mukhin wrote:
> I wonder if it's semantically ok: when _-mangling is performed?  do you need _
> at all?

Done.

https://chromiumcodereview.appspot.com/10702202/diff/1/lib/dom/scripts/genera...
lib/dom/scripts/generator.py:727: _idl_type_registry_properties = [
On 2012/07/13 15:18:55, Anton Mukhin wrote:
> as another option.
> 
> class TypeData(object):
>   def __init__(self,
>     dart_type=None,
>     native_type = None,
>     ...):
>   self._dart_type = dart_type
>   ...
> 
> now you'll have 'byte': TypeInfo(type='Primitive', dart_type='bool', ...)
> 
> which is more readable imho and requires no black magic.

Done.

https://chromiumcodereview.appspot.com/10702202/diff/1/lib/dom/scripts/system...
File lib/dom/scripts/systembase.py (right):

https://chromiumcodereview.appspot.com/10702202/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systembase.py:225: class GeneratorContext(object):
On 2012/07/13 15:18:55, Anton Mukhin wrote:
> GeneratorOptions?  GeneratorParameters?  Context is too broad imho

Done.

[Anton Muhin, 2012-07-13 16:08:43]

sweet, lgtm

https://chromiumcodereview.appspot.com/10702202/diff/6001/lib/dom/scripts/dar...
File lib/dom/scripts/dartdomgenerator.py (right):

https://chromiumcodereview.appspot.com/10702202/diff/6001/lib/dom/scripts/dar...
lib/dom/scripts/dartdomgenerator.py:80: context = CreateGeneratorOptions(
s/context/options?

[podivilov, 2012-07-16 09:26:47]

Thanks!

https://chromiumcodereview.appspot.com/10702202/diff/6001/lib/dom/scripts/dar...
File lib/dom/scripts/dartdomgenerator.py (right):

https://chromiumcodereview.appspot.com/10702202/diff/6001/lib/dom/scripts/dar...
lib/dom/scripts/dartdomgenerator.py:80: context = CreateGeneratorOptions(
On 2012/07/13 16:08:44, Anton Mukhin wrote:
> s/context/options?

Done.

[Anton Muhin, 2012-07-16 10:22:22]

https://chromiumcodereview.appspot.com/10702202/diff/8002/lib/dom/scripts/dar...
File lib/dom/scripts/dartgenerator.py (right):

https://chromiumcodereview.appspot.com/10702202/diff/8002/lib/dom/scripts/dar...
lib/dom/scripts/dartgenerator.py:290: def __init__(self, context):
options :)