Issue 10702186: Replaced simpleValue with more general reflectee. hasSimpleValue is retained internally for the sak…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10702186: Replaced simpleValue with more general reflectee. hasSimpleValue is retained internally for the sak… (Closed)

Created:
8 years, 5 months ago by rmacnak

Modified:
6 years, 6 months ago

Reviewers:
turnidge

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Replaced simpleValue with more general reflectee. hasSimpleValue is retained internally for the sake of safe printing: mirrors should not assume their reflectees toString will return quickly and without error. Committed: https://code.google.com/p/dart/source/detail?r=9637

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -45 lines)			Patch
M	lib/mirrors/mirrors.dart	View		1 chunk	+12 lines, -9 lines	0 comments	Download
M	runtime/lib/mirrors.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/lib/mirrors_impl.dart	View	1	2 chunks	+11 lines, -16 lines	0 comments	Download
M	runtime/tests/vm/dart/isolate_mirror_local_test.dart	View		7 chunks	+19 lines, -19 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rmacnak

8 years, 5 months ago (2012-07-12 22:34:25 UTC) #2

On 2012/07/12 22:06:56, rmacnak wrote:

Updated _LocalInstanceMirrorImpl to assume the reflectee and mirror are in the
same isolate. When this does not hold, a different InstanceMirror implemention
will be used.

Expand Messages | Collapse Messages