Fix bug in recompilation handling.

Fix bug in recompilation handling.

The recompilation infrastructure would set the propagated type of
operations just before code generation (skipping type propagation and
check insertion). This fixes that by splitting the recompilation
handling into two parts. One that is used only to register
recompilation candidates and one that is used to propagate the field
types for recompilation candidates. The one that propagates types is
only used when directly followed by type-propagation and check
insertion.

Remove the graph.highTypeLikelyhood flag which forced the use of
speculative type assumptions for everything if there was a field with
a likely type. That seems too aggressive to me.

R=floitsch@google.com
BUG=
TEST=language/field_optimization3_test.dart

Committed: https://code.google.com/p/dart/source/detail?r=9591

[floitsch, 2012-07-12 13:05:55]

LGTM.

https://chromiumcodereview.appspot.com/10702167/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/optimize.dart (right):

https://chromiumcodereview.appspot.com/10702167/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/optimize.dart:1208: if
(!node.element.enclosingElement.isClass()) return;
if (!node.element.isInstanceMember()) return; ?

[Mads Ager (google), 2012-07-12 13:09:58]

https://chromiumcodereview.appspot.com/10702167/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/optimize.dart (right):

https://chromiumcodereview.appspot.com/10702167/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/optimize.dart:1208: if
(!node.element.enclosingElement.isClass()) return;
On 2012/07/12 13:05:55, floitsch wrote:
> if (!node.element.isInstanceMember()) return; ?

That looks better, thanks. Done.