Issue 2622. Fix for SourceInfo for DartUnit for one case of invalid source

Issue 2622. Fix for SourceInfo for DartUnit for one case of invalid source
http://code.google.com/p/dart/issues/detail?id=2622


R=messick@google.com,brianwilkerson@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=9513

[messick, 2012-07-09 02:40:10]

lgtm

[Brian Wilkerson, 2012-07-09 13:55:40]

LGTM

https://chromiumcodereview.appspot.com/10702119/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

https://chromiumcodereview.appspot.com/10702119/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/parser/DartParser.java:2185: if
(!expect(Token.LPAREN)) {
Out of curiosity, what was causing the problem this fixes? Is it the fact that
the beginParameter() on line 2191 is unconditional, but the matching done() on
line 2205 is conditional? While there's nothing wrong with this change, perhaps
a better change would be to make the done() also be unconditional.

[scheglov, 2012-07-10 16:01:27]

https://chromiumcodereview.appspot.com/10702119/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/parser/DartParser.java (right):

https://chromiumcodereview.appspot.com/10702119/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/parser/DartParser.java:2185: if
(!expect(Token.LPAREN)) {
On 2012/07/09 13:55:40, Brian Wilkerson wrote:
> Out of curiosity, what was causing the problem this fixes? Is it the fact that
> the beginParameter() on line 2191 is unconditional, but the matching done() on
> line 2205 is conditional? While there's nothing wrong with this change,
perhaps
> a better change would be to make the done() also be unconditional.

Thank you, you are right, calling done() is better solution.