Issue 10702114: dart2dart: fix top level field declarations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10702114: dart2dart: fix top level field declarations. (Closed)

Created:
8 years, 5 months ago by Roman

Modified:
8 years, 5 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

dart2dart: fix top level field declarations. Unparse: final String x = "asd"; main() { x; } used to unparse to: x="asd"main(){x;} Now: final String x="asd";main(){x;} Committed: https://code.google.com/p/dart/source/detail?r=9465

Patch Set 1 #

Total comments: 2

Patch Set 2 : add todo #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -1 line)			Patch
	M	lib/compiler/implementation/dart_backend/backend.dart	View	1	1 chunk	+20 lines, -1 line	0 comments	Download
	M	tests/compiler/dart2js/unparser_test.dart	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

lgtm https://chromiumcodereview.appspot.com/10702114/diff/1/lib/compiler/implementation/dart_backend/backend.dart File lib/compiler/implementation/dart_backend/backend.dart (right): https://chromiumcodereview.appspot.com/10702114/diff/1/lib/compiler/implementation/dart_backend/backend.dart#newcode64 lib/compiler/implementation/dart_backend/backend.dart:64: sb.add(element.parseNode(compiler).unparse()); do we want to resort to node ...

8 years, 5 months ago (2012-07-06 13:55:48 UTC) #2

Roman

8 years, 5 months ago (2012-07-09 12:26:00 UTC) #3

https://chromiumcodereview.appspot.com/10702114/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/backend.dart (right):

https://chromiumcodereview.appspot.com/10702114/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/backend.dart:64:
sb.add(element.parseNode(compiler).unparse());
On 2012/07/06 13:55:48, antonmuhin wrote:
> do we want to resort to node unparse?  It might be helpful right now as it'll
> parse complicated initializer, but, please, add a TODO to reconsider it later
if
> we switch to element unparsing, ok?

Done.

Expand Messages | Collapse Messages