Serialize/deserialize lists in JS ports

Serialize/deserialize lists in JS ports

Committed: https://code.google.com/p/dart/source/detail?r=9452

[vsm, 2012-07-06 13:48:16]

LGTM with comments.

https://chromiumcodereview.appspot.com/10702113/diff/1/client/dart.js
File client/dart.js (right):

https://chromiumcodereview.appspot.com/10702113/diff/1/client/dart.js#newcode57
client/dart.js:57: return [ 'list', message.length, message ];
Hmm.  The elements of message should be serialized as well.  And, the map values
as well I think.

Feel free to add a TODO if you prefer.

https://chromiumcodereview.appspot.com/10702113/diff/1/client/dart.js#newcode88
client/dart.js:88: case 'list': return x[2];
I think you need to deserialized the elements of the list (see deserializeMap
below).

[sammccall, 2012-07-06 16:01:41]

I don't think I can commit this, I need you to do it :-)

I fixed another small bug (deserializing a local JS port didn't work). PTAL

https://chromiumcodereview.appspot.com/10702113/diff/1/client/dart.js
File client/dart.js (right):

https://chromiumcodereview.appspot.com/10702113/diff/1/client/dart.js#newcode57
client/dart.js:57: return [ 'list', message.length, message ];
On 2012/07/06 13:48:16, vsm wrote:
> Hmm.  The elements of message should be serialized as well.  And, the map
values
> as well I think.
> 
> Feel free to add a TODO if you prefer.

Done.

https://chromiumcodereview.appspot.com/10702113/diff/1/client/dart.js#newcode88
client/dart.js:88: case 'list': return x[2];
On 2012/07/06 13:48:16, vsm wrote:
> I think you need to deserialized the elements of the list (see deserializeMap
> below).

Done.

https://chromiumcodereview.appspot.com/10702113/diff/7001/client/dart.js
File client/dart.js (right):

https://chromiumcodereview.appspot.com/10702113/diff/7001/client/dart.js#newc...
client/dart.js:115: return new LocalSendPortSync(ReceivePortSync.map[id]);
I think this was just an oversight before?

[vsm, 2012-07-09 02:11:13]

LGTM and landed for you.  Thanks!