Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 10702112: Make sure we do not try to run main() before the document has been fully loaded. (Closed)

Created:
8 years, 5 months ago by kasperl
Modified:
8 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make sure we do not try to run main() before the document has been fully loaded. The problem was that document.readyState is either loading, interactive, or complete, so before this change we would sometimes run main() when the document has been parsed but not fully loaded. R=efortuna@google.com,vsm@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9434

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lib/compiler/implementation/emitter.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
kasperl
8 years, 5 months ago (2012-07-06 10:45:54 UTC) #1
Emily Fortuna
tricky! lgtm.
8 years, 5 months ago (2012-07-06 10:48:55 UTC) #2
vsm
LGTM, but I'll look into replacing this with something safer. If DOMContentLoaded fires before readyState ...
8 years, 5 months ago (2012-07-06 10:55:55 UTC) #3
Johnni Winther
This update breaks the behavior on my machine (Windows 7 with Chrome and/or Firefox). The ...
8 years, 5 months ago (2012-07-09 14:50:02 UTC) #4
vsm
8 years, 5 months ago (2012-07-09 14:59:36 UTC) #5
Johnni: This is what I was concerned about.  But, none of our win7 bots (chrome
or ff) have gone red.  Do you have a reliably breaking test case?

On 2012/07/09 14:50:02, Johnni Winther wrote:
> This update breaks the behavior on my machine (Windows 7 with Chrome and/or
> Firefox). The code finds the document.readyState to 'interactive' but the
event
> has already been fired, and the event handler is therefore never called.

Powered by Google App Engine
This is Rietveld 408576698