Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 10702092: Simplify adding of computations to the flow graph. (Closed)

Created:
8 years, 5 months ago by Kevin Millikin (Google)
Modified:
8 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Simplify adding of computations to the flow graph. In preparation for collapsing BindInstr/DoInstr and flattening Computations into the Instruction hierarchy. Add a pair of functions EffectGraphVisitor::Bind and EffectGraphVisitor::Do for adding computations to the flow graph that have respectively one and zero uses. This creates a single site where we construct new BindInstr and a single site where we construct new DoInstr (also, a single site where we construct new UseVal during flow graph construction). BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9407

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -295 lines) Patch
M runtime/vm/flow_graph_builder.h View 5 chunks +10 lines, -7 lines 0 comments Download
M runtime/vm/flow_graph_builder.cc View 33 chunks +190 lines, -288 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Google)
8 years, 5 months ago (2012-07-04 13:08:59 UTC) #1
Florian Schneider
8 years, 5 months ago (2012-07-04 13:40:23 UTC) #2
This looks already much cleaner.

LGTM!

Powered by Google App Engine
This is Rietveld 408576698