Issue 10702067: - Separate store buffer data in the isolate into the StoreBufferBlock and

Issue 10702067: - Separate store buffer data in the isolate into the StoreBufferBlock and (Closed)

Created:
8 years, 5 months ago by Ivan Posva

Modified:
8 years, 5 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, cshapiro

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Separate store buffer data in the isolate into the StoreBufferBlock and the actual StoreBuffer. - Add a HashSet class to use for the StoreBuffer data. - Fix allocation sites for definite old objects. - Remove obsolete leaf runtime entry StoreBuffer. Committed: https://code.google.com/p/dart/source/detail?r=9323

Patch Set 1 #

Total comments: 10

Patch Set 2 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+190 lines, -30 lines)			Patch
M	runtime/vm/assembler_test.cc	View	1	3 chunks	+7 lines, -7 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download
A	runtime/vm/hash_set.h	View	1	1 chunk	+97 lines, -0 lines	0 comments	Download
M	runtime/vm/isolate.h	View	1	2 chunks	+7 lines, -4 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	3 chunks	+8 lines, -6 lines	0 comments	Download
M	runtime/vm/store_buffer.h	View	1	2 chunks	+37 lines, -0 lines	0 comments	Download
M	runtime/vm/store_buffer.cc	View	1	1 chunk	+26 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/vm_sources.gypi	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://chromiumcodereview.appspot.com/10702067/diff/1/runtime/vm/hash_set.h File runtime/vm/hash_set.h (right): https://chromiumcodereview.appspot.com/10702067/diff/1/runtime/vm/hash_set.h#newcode38 runtime/vm/hash_set.h:38: bool Add(uword value) { Maybe we should add ...

8 years, 5 months ago (2012-07-02 20:57:42 UTC) #2

Ivan Posva

8 years, 5 months ago (2012-07-03 00:10:24 UTC) #3

https://chromiumcodereview.appspot.com/10702067/diff/1/runtime/vm/hash_set.h
File runtime/vm/hash_set.h (right):

https://chromiumcodereview.appspot.com/10702067/diff/1/runtime/vm/hash_set.h#...
runtime/vm/hash_set.h:38: bool Add(uword value) {
On 2012/07/02 20:57:42, asiva wrote:
> Maybe we should add a comment on the top that the caller should stop trying to
> add entries when it gets back a 'false' value.
> 
> Also we should probably have an assert
> ASSERT(count_< growth_limit_);
> at the beginning of this function.

Done.

https://chromiumcodereview.appspot.com/10702067/diff/1/runtime/vm/hash_set.h#...
runtime/vm/hash_set.h:56: bool Contains(uword value) {
On 2012/07/02 20:57:42, asiva wrote:
> bool Contains(uword value) const {

Done.

https://chromiumcodereview.appspot.com/10702067/diff/1/runtime/vm/store_buffe...
File runtime/vm/store_buffer.cc (right):

https://chromiumcodereview.appspot.com/10702067/diff/1/runtime/vm/store_buffe...
runtime/vm/store_buffer.cc:33: }
On 2012/07/02 20:57:42, asiva wrote:
> dedup_sets_ = NULL;

Done.

https://chromiumcodereview.appspot.com/10702067/diff/1/runtime/vm/store_buffe...
runtime/vm/store_buffer.cc:37: void StoreBuffer::AddPointer(uword address) {
On 2012/07/02 20:57:42, asiva wrote:
> ASSERT(dedup_sets_ != NULL);

Done.

https://chromiumcodereview.appspot.com/10702067/diff/1/runtime/vm/store_buffer.h
File runtime/vm/store_buffer.h (right):

https://chromiumcodereview.appspot.com/10702067/diff/1/runtime/vm/store_buffe...
runtime/vm/store_buffer.h:67: DedupSet() : set_(new HashSet(kSetSize,
kFillRatio)) {}
On 2012/07/02 20:57:42, asiva wrote:
> : next_(NULL) {}

Done.

Expand Messages | Collapse Messages