Issue 10701147: Implement more intrinisification for x64 (not as inlined code but as header of the target).

Issue 10701147: Implement more intrinisification for x64 (not as inlined code but as header of the target). (Closed)

Created:
8 years, 5 months ago by srdjan

Modified:
8 years, 5 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement more intrinisification for x64 (not as inlined code but as header of the target). Committed: https://code.google.com/p/dart/source/detail?r=9573

Patch Set 3 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+538 lines, -14 lines)			Patch
M	runtime/lib/array.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/assembler_x64.h	View	1 2	1 chunk	+14 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	1 2	3 chunks	+70 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_x64_test.cc	View	1 2	2 chunks	+120 lines, -0 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intrinsifier_x64.cc	View	1 2	6 chunks	+332 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10701147/diff/7001/runtime/vm/intrinsifier_x64.cc File runtime/vm/intrinsifier_x64.cc (right): https://chromiumcodereview.appspot.com/10701147/diff/7001/runtime/vm/intrinsifier_x64.cc#newcode493 runtime/vm/intrinsifier_x64.cc:493: __ addq(RAX, RCX); Why not a single instruction? ...

8 years, 5 months ago (2012-07-11 22:14:11 UTC) #2

srdjan

8 years, 5 months ago (2012-07-11 22:27:13 UTC) #3

Thanks, will add and test missing x64 instructions next.

https://chromiumcodereview.appspot.com/10701147/diff/7001/runtime/vm/intrinsi...
File runtime/vm/intrinsifier_x64.cc (right):

https://chromiumcodereview.appspot.com/10701147/diff/7001/runtime/vm/intrinsi...
runtime/vm/intrinsifier_x64.cc:493: __ addq(RAX, RCX);
On 2012/07/11 22:14:11, regis wrote:
> Why not a single instruction?
> __ addq(RAX, Address(RSP, + 2 * kWordSize));

We don't have such an instruction yet.

https://chromiumcodereview.appspot.com/10701147/diff/7001/runtime/vm/intrinsi...
runtime/vm/intrinsifier_x64.cc:543: __ imulq(RAX, RCX);
On 2012/07/11 22:14:11, regis wrote:
> Why not a single instruction?
> __ imulq(RAX, Address(RSP, + 2 * kWordSize));

ditto.

Expand Messages | Collapse Messages